Re: [PATCH] Add debugging helpers for ranger.

2021-06-17 Thread Aldy Hernandez via Gcc-patches
ute() routine use to do to fill > > the cache and dump state. > > > > I suspect this is driven by his threader work, and in that particular > > case, all he cares about is things that are exported so he isn't > > noticing the other things in the middle of the block :-

Re: [PATCH] Add debugging helpers for ranger.

2021-06-15 Thread Aldy Hernandez via Gcc-patches
re relevant. Bah. Indeed. Fixed. Aldy >From c26af6145e2ed3b97a277dbbd506328ee7e01d47 Mon Sep 17 00:00:00 2001 From: Aldy Hernandez Date: Mon, 14 Jun 2021 11:39:33 +0200 Subject: [PATCH] Add debugging helpers for ranger. These are debugging aids for help in debugging ranger based passes. gcc/

Re: [PATCH] Add debugging helpers for ranger.

2021-06-15 Thread Andrew MacLeod via Gcc-patches
On 6/15/21 9:48 AM, Jakub Jelinek wrote: On Tue, Jun 15, 2021 at 09:43:33AM -0400, Andrew MacLeod wrote: + basic_block bb; + int_range_max r; + FOR_EACH_BB_FN (bb, cfun) +{ + gimple *last = last_stmt (bb); + if (last && gimple_get_lhs (last)) + ranger.range_of_stmt (r, las

Re: [PATCH] Add debugging helpers for ranger.

2021-06-15 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 15, 2021 at 09:43:33AM -0400, Andrew MacLeod wrote: > > > + basic_block bb; > > > + int_range_max r; > > > + FOR_EACH_BB_FN (bb, cfun) > > > +{ > > > + gimple *last = last_stmt (bb); > > > + if (last && gimple_get_lhs (last)) > > > + ranger.range_of_stmt (r, last); > >

Re: [PATCH] Add debugging helpers for ranger.

2021-06-15 Thread Andrew MacLeod via Gcc-patches
On 6/15/21 7:55 AM, Jakub Jelinek via Gcc-patches wrote: On Tue, Jun 15, 2021 at 01:47:41PM +0200, Aldy Hernandez via Gcc-patches wrote: +// = +// Debugging helpers. +// = + +// Query all statements in the IL to prec

Re: [PATCH] Add debugging helpers for ranger.

2021-06-15 Thread Jakub Jelinek via Gcc-patches
On Tue, Jun 15, 2021 at 01:47:41PM +0200, Aldy Hernandez via Gcc-patches wrote: > +// = > +// Debugging helpers. > +// = > + > +// Query all statements in the IL to precalculate computable ranges in > RANGER. Not a re

[PATCH] Add debugging helpers for ranger.

2021-06-15 Thread Aldy Hernandez via Gcc-patches
These are aids to help in debugging ranger based passes. I find the ability to dump the current ranger knowledge for the function being debugged invaluable during development. Similarly for subsets of the CFG. Tested with a bootstrap and regtest, as well as countless sessions in gdb :). OK? gc