Re: [PATCH] Add comments to struct cgraph_thunk_info

2017-09-17 Thread Pierre-Marie de Rodat
On 09/16/2017 09:35 AM, Bernhard Reutner-Fischer wrote: + * for result-adjusting thinks, the FIXED_OFFSET adjustment is done after s/think/thunk/ TIA Good catch, thank you! I just pushed the following obvious change, as r252904: Fix a typo in a comment (cgraph.c:cgraph_thunk_info)

Re: [PATCH] Add comments to struct cgraph_thunk_info

2017-09-16 Thread Bernhard Reutner-Fischer
On 15 September 2017 18:20:33 CEST, Pierre-Marie de Rodat wrote: >On 09/15/2017 06:10 PM, Jeff Law wrote: >> OK. >> jeff > >Committed. Thanks! + * for result-adjusting thinks, the FIXED_OFFSET adjustment is done after s/think/thunk/ TIA

Re: [PATCH] Add comments to struct cgraph_thunk_info

2017-09-15 Thread Pierre-Marie de Rodat
On 09/15/2017 06:10 PM, Jeff Law wrote: OK. jeff Committed. Thanks! -- Pierre-Marie de Rodat

Re: [PATCH] Add comments to struct cgraph_thunk_info

2017-09-15 Thread Jeff Law
this since yesterday. ;-) > > Here it is! > > -- > Pierre-Marie de Rodat > > 0001-Add-comments-to-struct-cgraph_thunk_info.patch > > > From 601dd0e949f4af456a11036918da9dbadbb3aa0c Mon Sep 17 00:00:00 2001 > From: Pierre-Marie de Rodat > Date: Wed, 13 Sep 2017

Re: [PATCH] Add comments to struct cgraph_thunk_info

2017-09-15 Thread Pierre-Marie de Rodat
rom 601dd0e949f4af456a11036918da9dbadbb3aa0c Mon Sep 17 00:00:00 2001 From: Pierre-Marie de Rodat Date: Wed, 13 Sep 2017 16:21:04 +0200 Subject: [PATCH] Add comments to struct cgraph_thunk_info This commit adds comments to fields in the cgraph_thunk_info structure declaration from cgraph.h. They will hopefully ans

Re: [PATCH] Add comments to struct cgraph_thunk_info

2017-09-15 Thread Pierre-Marie de Rodat
On 09/14/2017 07:16 PM, Jeff Law wrote: The comment additions are fine. What's the rationale behind the ordering of the fields? In general we want the opposite order from what you did -- going from most strictly aligned to least strictly aligned minimizes the amount of unused padding. Thank y

Re: [PATCH] Add comments to struct cgraph_thunk_info

2017-09-14 Thread Jeff Law
On 09/14/2017 02:01 AM, Pierre-Marie de Rodat wrote: > Hello, > > This commit adds comments to fields in the cgraph_thunk_info structure > declaration from cgraph.h. They will hopefully answer questions that > people like myself can ask while discovering the thunk machinery. I > also made an asse

[PATCH] Add comments to struct cgraph_thunk_info

2017-09-14 Thread Pierre-Marie de Rodat
Hello, This commit adds comments to fields in the cgraph_thunk_info structure declaration from cgraph.h. They will hopefully answer questions that people like myself can ask while discovering the thunk machinery. I also made an assertion stricter in cgraph_node::create_thunk. I'm adding Nathan i