Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-06-05 Thread Michael Meissner
Jan Hubicka recently changed the calling sequence to init_lowered_empty_function, and my patch doesn't build any more. I cloned the changes made in the x86_64 port and committed the following change (subversion id 248902) so that the rs6000 build should build once again. 2017-06-05 Michael Meis

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-06-02 Thread Segher Boessenkool
On Fri, Jun 02, 2017 at 01:39:34PM -0400, Michael Meissner wrote: > > The patch is okay for trunk, but please test on AIX. > > You mentioned in private IRC that you would do the run on AIX, did you want me > to wait until it is finished? Yes please. Segher

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-06-02 Thread Michael Meissner
On Fri, Jun 02, 2017 at 11:55:57AM -0500, Segher Boessenkool wrote: > Hi! > > On Fri, Jun 02, 2017 at 10:16:27AM -0400, Michael Meissner wrote: > > > With "you don't have to give the enum a name" I meant write it as > > > > > > enum { > > > CLONE_DEFAULT = 0, > > > CLONE_ISA_2_05, > > > [...]

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-06-02 Thread Segher Boessenkool
Hi! On Fri, Jun 02, 2017 at 10:16:27AM -0400, Michael Meissner wrote: > > With "you don't have to give the enum a name" I meant write it as > > > > enum { > > CLONE_DEFAULT = 0, > > CLONE_ISA_2_05, > > [...] > > CLONE_MASK > > }; > > > > If you do "const int", I think it should be "static

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-06-02 Thread Michael Meissner
On Thu, Jun 01, 2017 at 03:43:22PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Wed, May 31, 2017 at 06:33:37PM -0400, Michael Meissner wrote: > > +/* On PowerPC, we have a limited number of target clones that we care about > > + which means we can use an array to hold the options, rather

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-06-01 Thread Segher Boessenkool
Hi Mike, On Wed, May 31, 2017 at 06:33:37PM -0400, Michael Meissner wrote: > +/* On PowerPC, we have a limited number of target clones that we care about > + which means we can use an array to hold the options, rather than having > more > + elaborate data structures to identify each possible

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-05-31 Thread Michael Meissner
On Wed, May 31, 2017 at 06:33:37PM -0400, Michael Meissner wrote: > Here is the updated version of the target_clone attribute support. > > The changes include: > > 1) Change the order of the CLONE priority list from default being 0 to ISA 3.0 > being the highest (and eliminating the enum and cast

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-05-31 Thread Michael Meissner
Here is the updated version of the target_clone attribute support. The changes include: 1) Change the order of the CLONE priority list from default being 0 to ISA 3.0 being the highest (and eliminating the enum and casts). 2) I tried to fix the various spacing issues. I found one place further

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-05-30 Thread Michael Meissner
On Tue, May 30, 2017 at 04:51:34PM -0500, Segher Boessenkool wrote: > Hi Mike, > > On Thu, May 25, 2017 at 04:05:39PM -0400, Michael Meissner wrote: > > +/* On PowerPC, we have a limited number of target clones that we care about > > + which means we can use an array to hold the options, rather

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-05-30 Thread Segher Boessenkool
Hi Mike, On Thu, May 25, 2017 at 04:05:39PM -0400, Michael Meissner wrote: > +/* On PowerPC, we have a limited number of target clones that we care about > + which means we can use an array to hold the options, rather than having > more > + elaborate data structures to identify each possible

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-05-25 Thread Michael Meissner
On Thu, May 25, 2017 at 09:56:20PM +0200, Florian Weimer wrote: > On Thu, May 25, 2017 at 8:25 PM, Michael Meissner > wrote: > > This patch adds the initial attribute((target_clone(...))) support to the > > Patch seems to be missing. > > Florian > Sorry about that. This patch adds the initial

Re: [PATCH] Add attribute((target_clone(...))) to PowerPC

2017-05-25 Thread Florian Weimer
On Thu, May 25, 2017 at 8:25 PM, Michael Meissner wrote: > This patch adds the initial attribute((target_clone(...))) support to the Patch seems to be missing. Florian

[PATCH] Add attribute((target_clone(...))) to PowerPC

2017-05-25 Thread Michael Meissner
This patch adds the initial attribute((target_clone(...))) support to the PowerPC. It looks at the HWCAP bits for ISA 2.05 (power6), ISA 2.06 (power7), ISA 2.07 (power8) and ISA 3.0 (power9) to determine which clone function to run. The implementation used the existing i386/x86_64 support for tar