Hi Frederik!
On 2020-01-31T13:17:52+0100, "Harwath, Frederik"
wrote:
> On 30.01.20 17:08, Thomas Schwinge wrote:
>
>> I understand correctly that the only reason for:
>>
>> On 2020-01-29T10:52:57+0100, "Harwath, Frederik"
>> wrote:
>>> * testsuite/libgomp.oacc-c-c++-common/acc_get_propert
Hi Thomas,
On 30.01.20 17:08, Thomas Schwinge wrote:
> I understand correctly that the only reason for:
>
> On 2020-01-29T10:52:57+0100, "Harwath, Frederik"
> wrote:
>> * testsuite/libgomp.oacc-c-c++-common/acc_get_property-aux.c
>> (expect_device_properties): Split function into ...
Hi!
On 2020-01-30T16:45:39+, Andrew Stubbs wrote:
> On 30/01/2020 16:08, Thomas Schwinge wrote:
>> Andrew and Frederik, thanks for your emails reminding/educating me about
>> 'snprintf' as well as this HSA fixed-size buffer API. There doesn't
>> happen to be something available in the HSA AP
On 30/01/2020 16:08, Thomas Schwinge wrote:
Hi!
Andrew and Frederik, thanks for your emails reminding/educating me about
'snprintf' as well as this HSA fixed-size buffer API. There doesn't
happen to be something available in the HSA API available so that we
could use 'sizeof [something]' instea
Hi!
Andrew and Frederik, thanks for your emails reminding/educating me about
'snprintf' as well as this HSA fixed-size buffer API. There doesn't
happen to be something available in the HSA API available so that we
could use 'sizeof [something]' instead of hard-coding '64' etc.?
I understand cor
Hi Thomas,
On 29.01.20 18:44, Thomas Schwinge wrote:
>> + size_t len = sizeof hsa_context.driver_version_s;
>> + int printed = snprintf (hsa_context.driver_version_s, len,
>> + "HSA Runtime %hu.%hu", (unsigned short int)major,
>> + (unsigned short int)m
On 29/01/2020 17:44, Thomas Schwinge wrote:
@@ -1513,6 +1518,23 @@ init_hsa_context (void)
+ size_t len = sizeof hsa_context.driver_version_s;
+ int printed = snprintf (hsa_context.driver_version_s, len,
+ "HSA Runtime %hu.%hu", (unsigned short int)major,
+
Hi!
On 2020-01-29T10:52:57+0100, "Harwath, Frederik"
wrote:
> On 28.01.20 16:42, Andrew Stubbs wrote:
>> On 28/01/2020 14:55, Harwath, Frederik wrote:
>>
>> If we're going to use a fixed-size buffer then we should use snprintf and
>> emit GCN_WARNING if the return value is greater than
>> "si
Hi Andrew,
On 29.01.20 11:38, Andrew Stubbs wrote:
> On 29/01/2020 09:52, Harwath, Frederik wrote:
>
> Patch 1 is OK with the formatting fixed.
> Patch 2 is OK.
>
> Thanks very much,
>
Committed as 2e5ea57959183bd5bd0356739bb5167417401a31 and
87c3fcfa6bbb5c372d4e275276d21f601d0b62b0.
Thank
On 29/01/2020 09:52, Harwath, Frederik wrote:
@@ -1513,6 +1518,23 @@ init_hsa_context (void)
GOMP_PLUGIN_error ("Failed to list all HSA runtime agents");
}
+ uint16_t minor, major;
+ status = hsa_fns.hsa_system_get_info_fn (HSA_SYSTEM_INFO_VERSION_MINOR,
&minor);
+ if (status
Hi Andrew,
On 28.01.20 16:42, Andrew Stubbs wrote:
> On 28/01/2020 14:55, Harwath, Frederik wrote:
>
> If we're going to use a fixed-size buffer then we should use snprintf and
> emit GCN_WARNING if the return value is greater than
> "sizeof(driver_version_s)", even though that is unlikely. Do
On 28/01/2020 14:55, Harwath, Frederik wrote:
Hi,
this patch adds full support for the OpenACC 2.6 acc_get_property and
acc_get_property_string functions to the libgomp GCN plugin. This replaces
the existing stub in libgomp/plugin-gcn.c.
Andrew: The value returned for acc_property_memory ("size
Best regards,
Frederik
From 6f1855281c38993a088f9b4af020a786f8e05fe9 Mon Sep 17 00:00:00 2001
From: Frederik Harwath
Date: Tue, 28 Jan 2020 08:01:00 +0100
Subject: [PATCH] Add OpenACC acc_get_property support for AMD GCN
Add full support for the OpenACC 2.6 acc_get_property and
acc_get_property_s
13 matches
Mail list logo
