Re: [PATCH] Add COBOL to gcc (was: Add 'cobol' to Makefile.def)

2024-11-08 Thread Jakub Jelinek
On Sat, Nov 02, 2024 at 03:56:49PM -0400, James K. Lowden wrote: > On Fri, 1 Nov 2024 20:27:21 +0100 > Jakub Jelinek wrote: > > > The second (which can only be committed when the first one is manually > > picked by one of gccadmins) should be just adding the ChangeLog. > ... > > see e.g. https://

Re: [PATCH] Add COBOL to gcc (was: Add 'cobol' to Makefile.def)

2024-11-03 Thread James K. Lowden
On Fri, 1 Nov 2024 20:27:21 +0100 Jakub Jelinek wrote: > The second (which can only be committed when the first one is manually > picked by one of gccadmins) should be just adding the ChangeLog. ... > see e.g. https://gcc.gnu.org/r13-4591 The technique here novel to me. Rather than a diff from

Re: [PATCH] Add COBOL to gcc (was: Add 'cobol' to Makefile.def)

2024-11-01 Thread Jakub Jelinek
On Thu, Oct 31, 2024 at 04:05:30PM -0400, James K. Lowden wrote: > >From ccb8a64c97461d792fdc39db249980a9ecb63b4bbld.patch 4 Oct 2024 12:01:22 > >-0400 > From: "James K. Lowden" > Date: Fri 01 Nov 2024 01:50:33 PM EDT > Subject: [PATCH] Add 'cobol' to 10 files > > ChangeLog > * Makefile.d

Re: [PATCH] Add COBOL to gcc (was: Add 'cobol' to Makefile.def)

2024-11-01 Thread Jakub Jelinek
On Thu, Oct 31, 2024 at 04:05:25PM -0400, James K. Lowden wrote: > On Tue, 29 Oct 2024 18:52:01 +0100 > Jakub Jelinek wrote: > > > > This 1st patch includes a stub cobol/ChangeLog, if that helps. > > > > It needs to go into a separate commit (i.e. register the new ChangeLog > > locations in on

Re: [PATCH] Add COBOL to gcc (was: Add 'cobol' to Makefile.def)

2024-11-01 Thread James K. Lowden
On Sat, 26 Oct 2024 13:41:32 -0400 "James K. Lowden" wrote: Below is a revised patch set incorporating recent feedback. Changes: * 2 patches: creation of gcc/cobo/ChangeLog now precedes "patch #1", the metafile patch * dead code (#if 0) removed * One new file included: changes to gcc/dwarf2out

Re: [PATCH] Add COBOL to gcc (was: Add 'cobol' to Makefile.def)

2024-11-01 Thread James K. Lowden
On Tue, 29 Oct 2024 18:52:01 +0100 Jakub Jelinek wrote: > > This 1st patch includes a stub cobol/ChangeLog, if that helps. > > It needs to go into a separate commit (i.e. register the new ChangeLog > locations in one commit, let gccadmins update the ~gccadmin copy of > it, then commit a patch

Re: [PATCH] Add COBOL to gcc (was: Add 'cobol' to Makefile.def)

2024-10-27 Thread James K. Lowden
On Wed, 23 Oct 2024 15:12:19 +0200 Richard Biener wrote: > The rest of the changes look OK to me. Below is a revised patch incorporating recent feedback. Changes: * remove blank lines at EOF * add gcc/cobol/lang.opt.urls * simpllify gcc/cobol/config-lang.in (and FE requires C++) * add stu