Re: [PATCH] Abstract out (forward) jump threader state handling.

2021-07-27 Thread Jeff Law via Gcc-patches
On 7/27/2021 10:21 AM, Aldy Hernandez wrote: On 7/27/21 5:15 PM, Jeff Law wrote: My recollection is there's also a case where the location of the state push/pops are highly unintuitive.  I always meant to put in some sanity checking on the push/pops, then go back and bring some sanity to t

Re: [PATCH] Abstract out (forward) jump threader state handling.

2021-07-27 Thread Aldy Hernandez via Gcc-patches
On 7/27/21 5:15 PM, Jeff Law wrote: My recollection is there's also a case where the location of the state push/pops are highly unintuitive.  I always meant to put in some sanity checking on the push/pops, then go back and bring some sanity to that code as well.  The one time I recall trying t

Re: [PATCH] Abstract out (forward) jump threader state handling.

2021-07-27 Thread Jeff Law via Gcc-patches
On 7/27/2021 4:19 AM, Aldy Hernandez wrote: The *forward* jump threader has multiple places where it pushes and pops state, and where it sets context up for the jump threading simplifier callback. Not only are the idioms repetitive, but the only reason for passing const_and_copies, avail_expr

[PATCH] Abstract out (forward) jump threader state handling.

2021-07-27 Thread Aldy Hernandez via Gcc-patches
The *forward* jump threader has multiple places where it pushes and pops state, and where it sets context up for the jump threading simplifier callback. Not only are the idioms repetitive, but the only reason for passing const_and_copies, avail_exprs_stack, and the evrp engine around are so we can