Re: [PATCH] ARMv6-M MI thunk fix

2013-06-20 Thread Cesar Philippidis
Ping. Cesar On 6/7/13 9:50 AM, Cesar Philippidis wrote: > On 6/6/13 9:00 AM, Richard Earnshaw wrote: >> The pipeline offset is 4 for Thumb2 as well. So at the very least you >> need to explain why your change doesn't apply then as well. > > Yes some context is lost in that comment. Thunks are

Re: [PATCH] ARMv6-M MI thunk fix

2013-06-11 Thread Julian Brown
On Tue, 11 Jun 2013 15:42:24 +0100 Julian Brown wrote: > Ahh -- so actually, maybe the right thing to do is use this last style > of thunk for v6-m, the same as v7-m -- is there any reason that > wouldn't work? (I wrote this patch to start with, but I don't remember > if I considered that possibi

Re: [PATCH] ARMv6-M MI thunk fix

2013-06-11 Thread Julian Brown
On Mon, 10 Jun 2013 09:02:24 -0700 Cesar Philippidis wrote: > On 6/10/13 8:32 AM, Richard Earnshaw wrote: > > On 07/06/13 17:50, Cesar Philippidis wrote: > >> On 6/6/13 9:00 AM, Richard Earnshaw wrote: > >>> The pipeline offset is 4 for Thumb2 as well. So at the very > >>> least you need to expl

Re: [PATCH] ARMv6-M MI thunk fix

2013-06-10 Thread Cesar Philippidis
On 6/10/13 8:32 AM, Richard Earnshaw wrote: > On 07/06/13 17:50, Cesar Philippidis wrote: >> On 6/6/13 9:00 AM, Richard Earnshaw wrote: >>> The pipeline offset is 4 for Thumb2 as well. So at the very least you >>> need to explain why your change doesn't apply then as well. >> >> Yes some context i

Re: [PATCH] ARMv6-M MI thunk fix

2013-06-10 Thread Richard Earnshaw
On 07/06/13 17:50, Cesar Philippidis wrote: On 6/6/13 9:00 AM, Richard Earnshaw wrote: The pipeline offset is 4 for Thumb2 as well. So at the very least you need to explain why your change doesn't apply then as well. Yes some context is lost in that comment. Thunks are usually emitted in ARM

Re: [PATCH] ARMv6-M MI thunk fix

2013-06-07 Thread Cesar Philippidis
On 6/6/13 9:00 AM, Richard Earnshaw wrote: > The pipeline offset is 4 for Thumb2 as well. So at the very least you > need to explain why your change doesn't apply then as well. Yes some context is lost in that comment. Thunks are usually emitted in ARM mode, except for Thumb-only targets. Is th

Re: [PATCH] ARMv6-M MI thunk fix

2013-06-06 Thread Richard Earnshaw
On 06/06/13 16:43, Cesar Philippidis wrote: This patch addresses the following FAILs on armv6-m: FAIL: g++.sum:g++.old-deja/g++.jason/thunk2.C -std=gnu++11 execution test FAIL: g++.sum:g++.old-deja/g++.jason/thunk2.C -std=gnu++98 execution test The source of the problem is the use of ARM

[PATCH] ARMv6-M MI thunk fix

2013-06-06 Thread Cesar Philippidis
This patch addresses the following FAILs on armv6-m: FAIL: g++.sum:g++.old-deja/g++.jason/thunk2.C -std=gnu++11 execution test FAIL: g++.sum:g++.old-deja/g++.jason/thunk2.C -std=gnu++98 execution test The source of the problem is the use of ARM thunk offsets for Thumb1. This test is using mu