Re: [PATCH] AArch64: Remove redundant check in aarch64_simd_mov

2024-10-18 Thread Kyrylo Tkachov
> On 17 Oct 2024, at 22:32, Victor Do Nascimento > wrote: > > FWIW, I definitely agree about the spuriousness of the V2DI mode check. > While I can't approve, I can confirm it looks good. Thanks for looking at it Victor. The patch is ok. Kyrill > > Thanks, > Victor. > > On 10/17/24 16:10,

Re: [PATCH] AArch64: Remove redundant check in aarch64_simd_mov

2024-10-17 Thread Victor Do Nascimento
FWIW, I definitely agree about the spuriousness of the V2DI mode check. While I can't approve, I can confirm it looks good. Thanks, Victor. On 10/17/24 16:10, Wilco Dijkstra wrote: The split condition in aarch64_simd_mov uses aarch64_simd_special_constant_p. While doing the split, it checks

[PATCH] AArch64: Remove redundant check in aarch64_simd_mov

2024-10-17 Thread Wilco Dijkstra
The split condition in aarch64_simd_mov uses aarch64_simd_special_constant_p. While doing the split, it checks the mode before calling aarch64_maybe_generate_simd_constant. This risky since it may result in unexpectedly calling aarch64_split_simd_move instead of aarch64_maybe_generate_simd_con