Re: [PATCH] AArch64: Add ACLE MOPS support

2024-05-31 Thread Richard Sandiford
Wilco Dijkstra writes: > Hi Richard, > >> I think this should be in a push_options/pop_options block, as for other >> intrinsics that require certain features. > > But then the intrinsic would always be defined, which is contrary to what the > ACLE spec demands - it would not give a compilation er

Re: [PATCH] AArch64: Add ACLE MOPS support

2024-05-31 Thread Kyrill Tkachov
Hi Wilco, On Fri, May 31, 2024 at 6:38 PM Wilco Dijkstra wrote: > Hi Richard, > > > I think this should be in a push_options/pop_options block, as for other > > intrinsics that require certain features. > > But then the intrinsic would always be defined, which is contrary to what > the > ACLE sp

Re: [PATCH] AArch64: Add ACLE MOPS support

2024-05-31 Thread Wilco Dijkstra
Hi Richard, > I think this should be in a push_options/pop_options block, as for other > intrinsics that require certain features. But then the intrinsic would always be defined, which is contrary to what the ACLE spec demands - it would not give a compilation error at the callsite but give assem

Re: [PATCH] AArch64: Add ACLE MOPS support

2024-05-31 Thread Richard Sandiford
Wilco Dijkstra writes: > Add __ARM_FEATURE_MOPS predefine. Add support for ACLE __arm_mops_memset_tag. > > Passes regress, OK for commit? > > gcc: > * config/aaarch64/aarch64-c.cc (aarch64_update_cpp_builtins): > Add __ARM_FEATURE_MOPS predefine. > * config/aarch64/arm_acl

[PATCH] AArch64: Add ACLE MOPS support

2024-05-31 Thread Wilco Dijkstra
Add __ARM_FEATURE_MOPS predefine. Add support for ACLE __arm_mops_memset_tag. Passes regress, OK for commit? gcc: * config/aaarch64/aarch64-c.cc (aarch64_update_cpp_builtins): Add __ARM_FEATURE_MOPS predefine. * config/aarch64/arm_acle.h: Add __arm_mops_memset_tag(). gc