On Fri, 2015-10-16 at 15:47 +0100, Marcus Shawcroft wrote:
> On 16 October 2015 at 15:31, Benedikt Huber
> wrote:
> > I introduced this in revision 7 due to a request from James Greenhalgh.
> > https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00963.html
> >
> >> Given that this is all so mechanical,
* config/aarch64/aarch64-builtins.c: Builtins for rsqrt and rsqrtf.
* config/aarch64/aarch64-protos.h: Declare.
* config/aarch64/aarch64-simd.md: Matching expressions for frsqrte and
frsqrts.
* config/aarch64/aarch64-tuning-flags.def: Added recip_sqrt.
On 16 October 2015 at 15:31, Benedikt Huber
wrote:
> I introduced this in revision 7 due to a request from James Greenhalgh.
> https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00963.html
>
>> Given that this is all so mechanical, I'd have a preference towards
>> refactoring this to loop over some str
I introduced this in revision 7 due to a request from James Greenhalgh.
https://gcc.gnu.org/ml/gcc-patches/2015-10/msg00963.html
> Given that this is all so mechanical, I'd have a preference towards
> refactoring this to loop over some structured data.
Do you mean, that I should get rid of the ty
On 16 October 2015 at 14:59, Benedikt Huber
wrote:
> + typedef struct
> + {
> +tree type_node;
> +const char *builtin_name;
> +int function_code;
> + } builtin_decls_data;
Please address Oleg's comment.
Cheers
/Marcus
* config/aarch64/aarch64-builtins.c: Builtins for rsqrt and rsqrtf.
* config/aarch64/aarch64-protos.h: Declare.
* config/aarch64/aarch64-simd.md: Matching expressions for frsqrte and
frsqrts.
* config/aarch64/aarch64-tuning-flags.def: Added recip_sqrt.
On Thu, 2015-10-15 at 22:03 +, Benedikt Huber wrote:
>
> +/* Add builtins for reciprocal square root. */
> +
> +void
> +aarch64_init_builtin_rsqrt (void)
> +{
> + tree fndecl = NULL;
> + tree ftype = NULL;
> +
> + tree V2SF_type_node = build_vector_type (float_type_node, 2);
> + tree V2D
Hi,
A few more style nits:
> + builtin_decls_data bdda[] = {
New line before {
> +{double_type_node, "__builtin_aarch64_rsqrt_df",
> AARCH64_BUILTIN_RSQRT_DF},
Space after {
Space before }
> +void aarch64_emit_swrsqrt (rtx, rtx);
> +
> +tree aarch64_builtin_rsqrt (unsigned int fn, b
* config/aarch64/aarch64-builtins.c: Builtins for rsqrt and rsqrtf.
* config/aarch64/aarch64-protos.h: Declare.
* config/aarch64/aarch64-simd.md: Matching expressions for frsqrte and
frsqrts.
* config/aarch64/aarch64-tuning-flags.def: Added recip_sqrt.
