Re: [PATCH] [rs6000] adjust return_pc debug attrs

2023-03-24 Thread Segher Boessenkool
Hi! On Thu, Mar 23, 2023 at 12:06:39AM -0300, Alexandre Oliva wrote: > On Mar 13, 2023, Segher Boessenkool wrote: > > Yes. On most architectures you can get multiple machine instructions of > > course (for long calls for example), but on rs6000 (with some ABIs, in > > some circumstances) we gene

Re: [PATCH] [rs6000] adjust return_pc debug attrs

2023-03-24 Thread Tom Tromey via Gcc-patches
> "Segher" == Segher Boessenkool writes: >> FWIW I sent a gdb patch to work around this bug. However, in my >> examples, I only ever saw a nop following the call instruction -- so I >> had gdb check for this. Segher> GCC inserts just a nop in most cases, but the linker or dynamic linker Seg

Re: [PATCH] [rs6000] adjust return_pc debug attrs

2023-03-22 Thread Alexandre Oliva via Gcc-patches
On Mar 13, 2023, Segher Boessenkool wrote: > Hi! > This is stage 1 stuff (or does it fix some regression or such?) > On Fri, Mar 03, 2023 at 03:00:02PM -0300, Alexandre Oliva wrote: >> Some of the rs6000 call patterns, on some ABIs, issue multiple opcodes >> out of a single call insn, but the ca

Re: [PATCH] [rs6000] adjust return_pc debug attrs

2023-03-17 Thread Segher Boessenkool
On Fri, Mar 17, 2023 at 10:33:22AM -0600, Tom Tromey wrote: > > "Segher" == Segher Boessenkool writes: > > Segher> Yes. On most architectures you can get multiple machine instructions > of > Segher> course (for long calls for example), but on rs6000 (with some ABIs, in > Segher> some circum

Re: [PATCH] [rs6000] adjust return_pc debug attrs

2023-03-17 Thread Tom Tromey via Gcc-patches
> "Segher" == Segher Boessenkool writes: Segher> Yes. On most architectures you can get multiple machine instructions of Segher> course (for long calls for example), but on rs6000 (with some ABIs, in Segher> some circumstances) we generate a nop insn after calls, so that the Segher> linker h

Re: [PATCH] [rs6000] adjust return_pc debug attrs

2023-03-13 Thread Segher Boessenkool
Hi! This is stage 1 stuff (or does it fix some regression or such?) On Fri, Mar 03, 2023 at 03:00:02PM -0300, Alexandre Oliva wrote: > Some of the rs6000 call patterns, on some ABIs, issue multiple opcodes > out of a single call insn, but the call (bl) or jump (b) is not always > the last opcode

[PATCH] [rs6000] adjust return_pc debug attrs

2023-03-03 Thread Alexandre Oliva via Gcc-patches
Some of the rs6000 call patterns, on some ABIs, issue multiple opcodes out of a single call insn, but the call (bl) or jump (b) is not always the last opcode in the sequence. This does not seem to be a problem for exception handling tables, but the return_pc attribute in the call graph output in