Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-11 Thread binbin via Gcc-patches
Hi, On 2020/3/10 上午10:30, binbin wrote: Hi, On 2020/3/9 下午10:32, Segher Boessenkool wrote: Hi! On Mon, Mar 09, 2020 at 01:58:01PM +0800, binbin wrote: 2020-03-09  Bin Bin Lv  * config/rs6000/rs6000-internal.h (altivec_builtin_mask_for_load, builtin_mode_to_type[MAX_MACHINE_MODE][2]

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-09 Thread binbin
Hi, On 2020/3/9 下午10:32, Segher Boessenkool wrote: Hi! On Mon, Mar 09, 2020 at 01:58:01PM +0800, binbin wrote: 2020-03-09 Bin Bin Lv * config/rs6000/rs6000-internal.h (altivec_builtin_mask_for_load, builtin_mode_to_type[MAX_MACHINE_MODE][2]): Remove the declaration. Just

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-09 Thread Segher Boessenkool
Hi! On Mon, Mar 09, 2020 at 01:58:01PM +0800, binbin wrote: > 2020-03-09 Bin Bin Lv > > * config/rs6000/rs6000-internal.h (altivec_builtin_mask_for_load, > builtin_mode_to_type[MAX_MACHINE_MODE][2]): Remove the declaration. Just write "builtin_mode_to_type", nothing []? Writing d

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-08 Thread binbin
Hi Segher, On 2020/3/5 下午6:42, Segher Boessenkool wrote: Hi Bin Bin, On Thu, Mar 05, 2020 at 10:31:39AM +0800, binbin wrote: On 2020/3/5 上午2:35, Segher Boessenkool wrote: On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: * config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include the

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-05 Thread Segher Boessenkool
Hi Bin Bin, On Thu, Mar 05, 2020 at 10:31:39AM +0800, binbin wrote: > On 2020/3/5 上午2:35, Segher Boessenkool wrote: > >On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: > * config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include the header file > for MAX_MACHINE_MODE. > >>> > >>>The c

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-04 Thread binbin
Hi Segher, On 2020/3/5 上午2:35, Segher Boessenkool wrote: On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: * config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include the header file for MAX_MACHINE_MODE. The changelog entry should say *what* file is included, and under what co

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-04 Thread Segher Boessenkool
On Wed, Mar 04, 2020 at 03:08:41PM +0800, binbin wrote: > >>* config/rs6000/rs6000.h (MAX_MACHINE_MODE): Include the header file > >>for MAX_MACHINE_MODE. > > > >The changelog entry should say *what* file is included, and under what > >condition. It doesn't have to say why (that belongs in

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-03 Thread binbin
Hi On 2020/3/4 上午8:25, Segher Boessenkool wrote: Hi! On Tue, Mar 03, 2020 at 09:40:47AM -0600, Bin Bin Lv wrote: The source file rs6000.c was split up into several smaller source files through commit 1acf024. However, variable "altivec_builtin_mask_for_load" and "builtin_mode_to_type[MAX_MACH

Re: [PATCH] [rs6000] Fix a wrong GC issue

2020-03-03 Thread Segher Boessenkool
Hi! On Tue, Mar 03, 2020 at 09:40:47AM -0600, Bin Bin Lv wrote: > The source file rs6000.c was split up into several smaller source files > through commit 1acf024. However, variable "altivec_builtin_mask_for_load" and > "builtin_mode_to_type[MAX_MACHINE_MODE][2]" were marked with the wrong syntax

[PATCH] [rs6000] Fix a wrong GC issue

2020-03-03 Thread Bin Bin Lv
Hi, The source file rs6000.c was split up into several smaller source files through commit 1acf024. However, variable "altivec_builtin_mask_for_load" and "builtin_mode_to_type[MAX_MACHINE_MODE][2]" were marked with the wrong syntax "GTY(([options])) type name", which led these two variables were