Re: [PATCH] [range-ops] Add ability to represent open intervals in frange.

2022-11-12 Thread Aldy Hernandez via Gcc-patches
On Sat, Nov 12, 2022 at 9:54 AM Jakub Jelinek wrote: > > On Fri, Nov 11, 2022 at 08:25:15PM +0100, Aldy Hernandez wrote: > > Passes tests for all languages. Passes lapack tests. > > > > So ready to be installed unless you have any issues. Oh... I should > > write some tests.. > > LGTM. > > Yea

Re: [PATCH] [range-ops] Add ability to represent open intervals in frange.

2022-11-12 Thread Jakub Jelinek via Gcc-patches
On Fri, Nov 11, 2022 at 08:25:15PM +0100, Aldy Hernandez wrote: > Passes tests for all languages. Passes lapack tests. > > So ready to be installed unless you have any issues. Oh... I should > write some tests.. LGTM. Yeah, for tests we still need to decide whether we make tests in the style

Re: [PATCH] [range-ops] Add ability to represent open intervals in frange.

2022-11-11 Thread Aldy Hernandez via Gcc-patches
Passes tests for all languages. Passes lapack tests. So ready to be installed unless you have any issues. Oh... I should write some tests.. Aldy On Fri, Nov 11, 2022, 19:11 Aldy Hernandez wrote: > Currently we represent < and > with a closed interval. So < 3.0 is > represented as [-INF, +

[PATCH] [range-ops] Add ability to represent open intervals in frange.

2022-11-11 Thread Aldy Hernandez via Gcc-patches
Currently we represent < and > with a closed interval. So < 3.0 is represented as [-INF, +3.0]. This means 3.0 is included in the range, and though not ideal, is conservatively correct. Jakub has found a couple cases where properly representing < and > would help optimizations and tests, and thi