Re: [PATCH] [og8] Allow optional arguments to be used in the use_device OpenACC clause

2019-02-01 Thread Kwok Cheung Yeung
I have retested all the failing cases and they now pass with the attached patch. I will commit this to openacc-gcc-8-branch now as the fix is obvious. Kwok On 01/02/2019 6:02 pm, Kwok Cheung Yeung wrote: There is an error in the logic here: --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -8938,18

Re: [PATCH] [og8] Allow optional arguments to be used in the use_device OpenACC clause

2019-02-01 Thread Kwok Cheung Yeung
There is an error in the logic here: --- a/gcc/omp-low.c +++ b/gcc/omp-low.c @@ -8938,18 +8938,51 @@ lower_omp_target (gimple_stmt_iterator *gsi_p, omp_context *ctx) tkind = GOMP_MAP_FIRSTPRIVATE_INT; type = TREE_TYPE (ovar); if (TREE_CODE (type) == ARRAY_T

Re: [PATCH] [og8] Allow optional arguments to be used in the use_device OpenACC clause

2019-02-01 Thread Thomas Schwinge
Hi Kwok! On Thu, 31 Jan 2019 18:30:35 +, Kwok Cheung Yeung wrote: > This patch allows for the use of Fortran optional arguments in the > use_device clause of a host_data directive. > > I will push this into openacc-gcc-8-branch later today. Per my testing, it unfortunately also introduces

[PATCH] [og8] Allow optional arguments to be used in the use_device OpenACC clause

2019-01-31 Thread Kwok Cheung Yeung
This patch allows for the use of Fortran optional arguments in the use_device clause of a host_data directive. I will push this into openacc-gcc-8-branch later today. Kwok Optional arguments should be treated as references rather than pointers in the lowering. However, for non-present argume