Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-19 Thread James Hilliard
On Tue, Mar 19, 2019 at 3:56 AM Jakub Jelinek wrote: > > On Mon, Mar 18, 2019 at 06:35:12PM -0600, James Hilliard wrote: > > On Mon, Mar 18, 2019 at 5:46 PM Jeff Law wrote: > > > > > > On 3/18/19 5:07 PM, James Hilliard wrote: > > > > On Mon, Mar 18, 2019 at 4:51 PM Jakub Jelinek wrote: > > > >>

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-19 Thread Jakub Jelinek
On Mon, Mar 18, 2019 at 06:35:12PM -0600, James Hilliard wrote: > On Mon, Mar 18, 2019 at 5:46 PM Jeff Law wrote: > > > > On 3/18/19 5:07 PM, James Hilliard wrote: > > > On Mon, Mar 18, 2019 at 4:51 PM Jakub Jelinek wrote: > > >> > > >> On Mon, Mar 18, 2019 at 04:41:05PM -0600, James Hilliard wro

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread James Hilliard
On Mon, Mar 18, 2019 at 6:58 PM Jeff Law wrote: > > On 3/18/19 6:35 PM, James Hilliard wrote: > > On Mon, Mar 18, 2019 at 5:46 PM Jeff Law wrote: > >> > >> On 3/18/19 5:07 PM, James Hilliard wrote: > >>> On Mon, Mar 18, 2019 at 4:51 PM Jakub Jelinek wrote: > > On Mon, Mar 18, 2019 at 0

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread Jeff Law
On 3/18/19 6:35 PM, James Hilliard wrote: > On Mon, Mar 18, 2019 at 5:46 PM Jeff Law wrote: >> >> On 3/18/19 5:07 PM, James Hilliard wrote: >>> On Mon, Mar 18, 2019 at 4:51 PM Jakub Jelinek wrote: On Mon, Mar 18, 2019 at 04:41:05PM -0600, James Hilliard wrote: >> Thanks, but I'm say

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread James Hilliard
On Mon, Mar 18, 2019 at 5:46 PM Jeff Law wrote: > > On 3/18/19 5:07 PM, James Hilliard wrote: > > On Mon, Mar 18, 2019 at 4:51 PM Jakub Jelinek wrote: > >> > >> On Mon, Mar 18, 2019 at 04:41:05PM -0600, James Hilliard wrote: > Thanks, but I'm saying that if you look at the code you can see t

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread Jeff Law
On 3/18/19 5:07 PM, James Hilliard wrote: > On Mon, Mar 18, 2019 at 4:51 PM Jakub Jelinek wrote: >> >> On Mon, Mar 18, 2019 at 04:41:05PM -0600, James Hilliard wrote: Thanks, but I'm saying that if you look at the code you can see that st is clearly initialized, by the call to lstat. I

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread James Hilliard
On Mon, Mar 18, 2019 at 4:51 PM Jakub Jelinek wrote: > > On Mon, Mar 18, 2019 at 04:41:05PM -0600, James Hilliard wrote: > > > Thanks, but I'm saying that if you look at the code you can see that > > > st is clearly initialized, by the call to lstat. I would like to see > > > an explanation for w

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread Jakub Jelinek
On Mon, Mar 18, 2019 at 04:41:05PM -0600, James Hilliard wrote: > > Thanks, but I'm saying that if you look at the code you can see that > > st is clearly initialized, by the call to lstat. I would like to see > > an explanation for why you are seeing that warning before changing the > > code to d

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread James Hilliard
On Mon, Mar 18, 2019 at 2:05 PM Ian Lance Taylor wrote: > > On Mon, Mar 18, 2019 at 11:57 AM James Hilliard > wrote: > > > > On Mon, Mar 18, 2019 at 11:19 AM Ian Lance Taylor wrote: > > > > > > On Sun, Mar 17, 2019 at 6:22 PM wrote: > > > > > > > > From: James Hilliard > > > > > > > > Fixes er

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread Ian Lance Taylor via gcc-patches
On Mon, Mar 18, 2019 at 11:57 AM James Hilliard wrote: > > On Mon, Mar 18, 2019 at 11:19 AM Ian Lance Taylor wrote: > > > > On Sun, Mar 17, 2019 at 6:22 PM wrote: > > > > > > From: James Hilliard > > > > > > Fixes error: ‘st.st_mode’ may be used uninitialized in this function > > > --- > > > l

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread James Hilliard
On Mon, Mar 18, 2019 at 11:19 AM Ian Lance Taylor wrote: > > On Sun, Mar 17, 2019 at 6:22 PM wrote: > > > > From: James Hilliard > > > > Fixes error: ‘st.st_mode’ may be used uninitialized in this function > > --- > > libbacktrace/elf.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-18 Thread Ian Lance Taylor via gcc-patches
On Sun, Mar 17, 2019 at 6:22 PM wrote: > > From: James Hilliard > > Fixes error: ‘st.st_mode’ may be used uninitialized in this function > --- > libbacktrace/elf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libbacktrace/elf.c b/libbacktrace/elf.c > index f3988ec02a0

[PATCH] [libbacktrace] Initialize st in elf_is_symlink

2019-03-17 Thread james . hilliard1
From: James Hilliard Fixes error: ‘st.st_mode’ may be used uninitialized in this function --- libbacktrace/elf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libbacktrace/elf.c b/libbacktrace/elf.c index f3988ec02a0..714bfec965d 100644 --- a/libbacktrace/elf.c +++ b/libbac