Re: [PATCH] [dlang/phobos] S/390: Fix PR91628

2019-11-28 Thread Robin Dapp
> OK from me, what about earlier comments of using __asm__ in a C > source file? > > I wouldn't really object to converting all .S sources (infact I can > do this myself) if it meant slightly better portability. Adding to yesterday's message: feel free to apply the current version if it's OK. Th

Re: [PATCH] [dlang/phobos] S/390: Fix PR91628

2019-11-27 Thread Robin Dapp
Hi Iain, > OK from me, what about earlier comments of using __asm__ in a C > source file? I don't mind too much either way but I gathered from the discussion in the bugzilla that .S was preferred for now. Regards Robin

Re: [PATCH] [dlang/phobos] S/390: Fix PR91628

2019-11-27 Thread Iain Buclaw
‐‐‐ Original Message ‐‐‐ On Wednesday, 27 November 2019 10:33, Robin Dapp wrote: > Hi, > > in order to not use a glibc-internal symbol anymore, this patch adds > separate .S files for s390x and s390 that allow to obtain the tls offset. > > I bootstrapped on s390x -m64 and -m31 and test on

[PATCH] [dlang/phobos] S/390: Fix PR91628

2019-11-27 Thread Robin Dapp
Hi, in order to not use a glibc-internal symbol anymore, this patch adds separate .S files for s390x and s390 that allow to obtain the tls offset. I bootstrapped on s390x -m64 and -m31 and test on s390x, s390 seeing no new regressions. Regards Robin -- libphobos/ChangeLog: 2019-11-27 Robin