Re: [PATCH] [PR87012] canonicalize ref type for tmpl arg

2018-12-19 Thread Alexandre Oliva
On Dec 14, 2018, Jason Merrill wrote: > Yes, like that, thanks. It might be a bit of an optimization to skip > this when t == TREE_TYPE (parm). OK either way. Thanks, I've put the suggested optimization in. Here's what I'm about to install. [PR87012] canonicalize ref type for tmpl arg When

Re: [PATCH] [PR87012] canonicalize ref type for tmpl arg

2018-12-14 Thread Jason Merrill
On Thu, Dec 13, 2018 at 8:37 PM Alexandre Oliva wrote: > On Dec 5, 2018, Jason Merrill wrote: > > > I would expect that this same issue would come up with other types; I > > think we want to fix this sooner, when we are figuring out what type > > we want to convert the argument to. > > You mean

Re: [PATCH] [PR87012] canonicalize ref type for tmpl arg

2018-12-13 Thread Alexandre Oliva
On Dec 5, 2018, Jason Merrill wrote: > I would expect that this same issue would come up with other types; I > think we want to fix this sooner, when we are figuring out what type > we want to convert the argument to. You mean like this? [PR87012] canonicalize ref type for tmpl arg When bindi

Re: [PATCH] [PR87012] canonicalize ref type for tmpl arg

2018-12-05 Thread Jason Merrill
On 11/16/18 5:32 PM, Alexandre Oliva wrote: When binding an object to a template parameter of reference type, we take the address of the object and dereference that address. The type of the address may still carry (template) typedefs, but verify_unstripped_args_1 rejects such typedefs other than

[PATCH] [PR87012] canonicalize ref type for tmpl arg

2018-11-16 Thread Alexandre Oliva
When binding an object to a template parameter of reference type, we take the address of the object and dereference that address. The type of the address may still carry (template) typedefs, but verify_unstripped_args_1 rejects such typedefs other than in the top level of template arguments. We m