Re: [PATCH] [PR105455] Set edge probabilities when hardening conditionals

2022-05-12 Thread Richard Biener via Gcc-patches
On Fri, May 13, 2022 at 8:03 AM Alexandre Oliva wrote: > > On May 12, 2022, Richard Biener wrote: > > >> Regstrapped on x86_64-linux-gnu. Ok to install? > > > OK. > > Thanks. I failed to ask, but I'm confident this is also ok for gcc-12, > so I'm putting it in there as well. Please let me know

Re: [PATCH] [PR105455] Set edge probabilities when hardening conditionals

2022-05-12 Thread Alexandre Oliva via Gcc-patches
On May 12, 2022, Richard Biener wrote: >> Regstrapped on x86_64-linux-gnu. Ok to install? > OK. Thanks. I failed to ask, but I'm confident this is also ok for gcc-12, so I'm putting it in there as well. Please let me know otherwise. >> PR rtl-optimization/105455 >> * gimple-harden-condition

Re: [PATCH] [PR105455] Set edge probabilities when hardening conditionals

2022-05-12 Thread Richard Biener via Gcc-patches
On Thu, May 12, 2022 at 3:48 AM Alexandre Oliva via Gcc-patches wrote: > > > When turning unconditional edges into conditional, as in > gimple-harden-conditionals.cc:insert_check_and_trap, the newly-created > edge's probability comes out uninitialized, while the previously > unconditional edge's p

[PATCH] [PR105455] Set edge probabilities when hardening conditionals

2022-05-11 Thread Alexandre Oliva via Gcc-patches
When turning unconditional edges into conditional, as in gimple-harden-conditionals.cc:insert_check_and_trap, the newly-created edge's probability comes out uninitialized, while the previously unconditional edge's probability is presumably profile_probability::always. Mixing initialized and unin