Re: [PATCH] [LRA] Fix wrong-code PR 91109 take 2

2019-08-16 Thread Vladimir Makarov
On 2019-08-16 11:06 a.m., Vladimir Makarov wrote: On 2019-08-15 3:46 p.m., Bernd Edlinger wrote: Hi, as discussed in the PR 91109 audit trail, my previous patch missed a case where no spilling is necessary, but the re-materialized instruction has now scratch regs without a hard register assi

Re: [PATCH] [LRA] Fix wrong-code PR 91109 take 2

2019-08-16 Thread Vladimir Makarov
On 2019-08-15 3:46 p.m., Bernd Edlinger wrote: Hi, as discussed in the PR 91109 audit trail, my previous patch missed a case where no spilling is necessary, but the re-materialized instruction has now scratch regs without a hard register assignment. And thus the LRA pass falls out of the loop

Re: [PATCH] [LRA] Fix wrong-code PR 91109 take 2

2019-08-16 Thread Bernd Edlinger
On 8/15/19 9:46 PM, Bernd Edlinger wrote: > Hi, > > as discussed in the PR 91109 audit trail, > my previous patch missed a case where no spilling is necessary, > but the re-materialized instruction has now scratch regs without > a hard register assignment. And thus the LRA pass falls out of > the

[PATCH] [LRA] Fix wrong-code PR 91109 take 2

2019-08-15 Thread Bernd Edlinger
Hi, as discussed in the PR 91109 audit trail, my previous patch missed a case where no spilling is necessary, but the re-materialized instruction has now scratch regs without a hard register assignment. And thus the LRA pass falls out of the loop pre-maturely. Fixed by checking for scratch regs