Re: [PATCH] [Annotalysis] Support trylock attributes on virtual methods.

2011-11-10 Thread Diego Novillo
On 11-11-10 17:23 , Delesley Hutchins wrote: +{ + tree callee = gimple_call_fn (call); + if (TREE_CODE (callee) == OBJ_TYPE_REF) +{ + tree objtype = TREE_TYPE (TREE_TYPE (OBJ_TYPE_REF_OBJECT (callee))); + /* Check to make sure objtype is a valid type. +

Re: [PATCH] [Annotalysis] Support trylock attributes on virtual methods.

2011-11-10 Thread Delesley Hutchins
> What about the other spots where we call gimple_call_fndecl, shouldn't we > call get_fdecl_from_gimple_stmt instead? Good point. I've gone through and updated the necessary spots. New patch with all fixes is attached. -DeLesley -- DeLesley Hutchins | Software Engineer | deles...@google.

Re: [PATCH] [Annotalysis] Support trylock attributes on virtual methods.

2011-11-10 Thread Diego Novillo
On 11-11-08 13:11 , Delesley Hutchins wrote: This patch fixes a bug wherein the trylock attribute would not work if it was attached to a virtual method. Bootstrapped and passed gcc regression testsuite on x86_64-unknown-linux-gnu. Okay for google/gcc-4_6? -DeLesley Changelog.google-4_6: 201

Re: [PATCH] [Annotalysis] Support trylock attributes on virtual methods.

2011-11-08 Thread Ollie Wild
On Tue, Nov 8, 2011 at 12:11 PM, Delesley Hutchins wrote: > This patch fixes a bug wherein the trylock attribute would not work if > it was attached to a virtual method. Diego, can you please review this? Thanks, Ollie

[PATCH] [Annotalysis] Support trylock attributes on virtual methods.

2011-11-08 Thread Delesley Hutchins
This patch fixes a bug wherein the trylock attribute would not work if it was attached to a virtual method. Bootstrapped and passed gcc regression testsuite on x86_64-unknown-linux-gnu. Okay for google/gcc-4_6? -DeLesley Changelog.google-4_6: 2011-11-08 DeLesley Hutchins * tree-threadsaf