Re: [PATCH][v2] rtl-optimization/105231 - distribute_notes and REG_EH_REGION

2022-04-19 Thread Segher Boessenkool
On Tue, Apr 19, 2022 at 05:00:12PM +0200, Richard Biener wrote: > On Tue, 19 Apr 2022, Segher Boessenkool wrote: > > > > And that always is safe? Why do we have REG_EH_REGION for those cases > > > > at all, then? > > > > > > It's the only "safe" thing to do at distribute_notes time I think. If >

Re: [PATCH][v2] rtl-optimization/105231 - distribute_notes and REG_EH_REGION

2022-04-19 Thread Richard Biener via Gcc-patches
On Tue, 19 Apr 2022, Segher Boessenkool wrote: > On Tue, Apr 19, 2022 at 02:58:26PM +0200, Richard Biener wrote: > > On Tue, 19 Apr 2022, Segher Boessenkool wrote: > > The assert was for any landing pad which obviously failed - the > > testsuite fails were all for MUST_NOT_THROW (negative) regions

Re: [PATCH][v2] rtl-optimization/105231 - distribute_notes and REG_EH_REGION

2022-04-19 Thread Segher Boessenkool
On Tue, Apr 19, 2022 at 02:58:26PM +0200, Richard Biener wrote: > On Tue, 19 Apr 2022, Segher Boessenkool wrote: > The assert was for any landing pad which obviously failed - the > testsuite fails were all for MUST_NOT_THROW (negative) regions > which do not end basic-blocks. I see, thanks. > > >

Re: [PATCH][v2] rtl-optimization/105231 - distribute_notes and REG_EH_REGION

2022-04-19 Thread Richard Biener via Gcc-patches
On Tue, 19 Apr 2022, Segher Boessenkool wrote: > Hi! > > So the assert last week was for a landing pad <= 0? < or =? The assert was for any landing pad which obviously failed - the testsuite fails were all for MUST_NOT_THROW (negative) regions which do not end basic-blocks. > On Tue, Apr 19, 2

Re: [PATCH][v2] rtl-optimization/105231 - distribute_notes and REG_EH_REGION

2022-04-19 Thread Segher Boessenkool
Hi! So the assert last week was for a landing pad <= 0? < or =? On Tue, Apr 19, 2022 at 01:02:09PM +0200, Richard Biener wrote: > The following mitigates a problem in combine distribute_notes which > places an original REG_EH_REGION based on only may_trap_p which is > good to test whether a non-

[PATCH][v2] rtl-optimization/105231 - distribute_notes and REG_EH_REGION

2022-04-19 Thread Richard Biener via Gcc-patches
The following mitigates a problem in combine distribute_notes which places an original REG_EH_REGION based on only may_trap_p which is good to test whether a non-call insn can possibly throw but not if actually it does or we care. That's something we decided at RTL expansion time where we possibly