Re: [PATCH][rs6000] better use of unaligned vsx in memset() expansion

2018-11-28 Thread Segher Boessenkool
On Wed, Nov 28, 2018 at 01:24:01PM -0600, Aaron Sawdey wrote: > The first version of this had a big bug and cleared past the requested bytes. > This version passes regstrap on ppc64le(power7/8/9), ppc64be(power6/7/8), > and ppc32(power8). > > OK for trunk (and 8 backport after a week)? > @@ -91,8

Re: [PATCH][rs6000] better use of unaligned vsx in memset() expansion

2018-11-28 Thread Aaron Sawdey
The first version of this had a big bug and cleared past the requested bytes. This version passes regstrap on ppc64le(power7/8/9), ppc64be(power6/7/8), and ppc32(power8). OK for trunk (and 8 backport after a week)? Thanks! Aaron Index: gcc/config/rs6000/rs6000-string.c ===

Re: [PATCH][rs6000] better use of unaligned vsx in memset() expansion

2018-11-26 Thread Segher Boessenkool
On Mon, Nov 26, 2018 at 03:08:32PM -0600, Aaron Sawdey wrote: > When I previously added the use of unaligned vsx stores to inline expansion > of memset, I didn't do a good job of managing boundary conditions. The > intention > was to only use unaligned vsx if the block being cleared was more than

[PATCH][rs6000] better use of unaligned vsx in memset() expansion

2018-11-26 Thread Aaron Sawdey
When I previously added the use of unaligned vsx stores to inline expansion of memset, I didn't do a good job of managing boundary conditions. The intention was to only use unaligned vsx if the block being cleared was more than 32 bytes. What it actually did was to prevent the use of unaligned vsx