Re: [PATCH][openmp, simt] Error out for user-defined reduction

2021-05-18 Thread Thomas Schwinge
Hi! On 2021-05-03T19:03:24+0200, Tom de Vries wrote: > --- /dev/null > +++ b/libgomp/testsuite/libgomp.c/target-44.c > @@ -0,0 +1,27 @@ > +/* { dg-additional-options "-foffload=-latomic" { target { > offload_target_nvptx } } } */ Causes issues if more than nvptx offloading compilation is enable

Re: [PATCH][openmp, simt] Error out for user-defined reduction

2021-05-03 Thread Jakub Jelinek via Gcc-patches
On Mon, May 03, 2021 at 07:03:24PM +0200, Tom de Vries wrote: > + if (sctx->is_simt && !known_eq (sctx->max_vf, 1U)) > + { > + tree c = omp_find_clause (gimple_omp_for_clauses (ctx->stmt), > + OMP_CLAUSE_REDUCTION); > + if (c && OMP_CLAUSE_REDUCT

Re: [PATCH][openmp, simt] Error out for user-defined reduction

2021-05-03 Thread Tom de Vries
On 5/3/21 12:31 PM, Jakub Jelinek wrote: > On Mon, May 03, 2021 at 12:24:10PM +0200, Tom de Vries wrote: >> The test-case included in this patch contains this target region: >> ... >> for (int i0 = 0 ; i0 < N0 ; i0++ ) >> counter_N0.i += 1; >> ... >> >> When running with nvptx accelerator, th

Re: [PATCH][openmp, simt] Error out for user-defined reduction

2021-05-03 Thread Jakub Jelinek via Gcc-patches
On Mon, May 03, 2021 at 12:24:10PM +0200, Tom de Vries wrote: > The test-case included in this patch contains this target region: > ... > for (int i0 = 0 ; i0 < N0 ; i0++ ) > counter_N0.i += 1; > ... > > When running with nvptx accelerator, the counter variable is expected to > be N0 after t

[PATCH][openmp, simt] Error out for user-defined reduction

2021-05-03 Thread Tom de Vries
Hi, The test-case included in this patch contains this target region: ... for (int i0 = 0 ; i0 < N0 ; i0++ ) counter_N0.i += 1; ... When running with nvptx accelerator, the counter variable is expected to be N0 after the region, but instead is N0 / 32. The problem is that rather than getti