Re: [PATCH][libgomp, testsuite] Fix hardcoded libexec in plugin/configfrag.ac

2022-03-28 Thread Tom de Vries via Gcc-patches
On 3/28/22 14:04, Richard Biener wrote: On Mon, 28 Mar 2022, Andreas Schwab wrote: On Mär 28 2022, Richard Biener via Gcc-patches wrote: OK in principle, but I have no idea on how portable $(libexecdir:\$(exec_prefix)/%=%) is going to be? We already require GNU make, don't we? We should

Re: [PATCH][libgomp, testsuite] Fix hardcoded libexec in plugin/configfrag.ac

2022-03-28 Thread Richard Biener via Gcc-patches
On Mon, 28 Mar 2022, Andreas Schwab wrote: > On Mär 28 2022, Richard Biener via Gcc-patches wrote: > > > OK in principle, but I have no idea on how portable > > > > $(libexecdir:\$(exec_prefix)/%=%) > > > > is going to be? > > We already require GNU make, don't we? > > > We should aim for POSIX

Re: [PATCH][libgomp, testsuite] Fix hardcoded libexec in plugin/configfrag.ac

2022-03-28 Thread Andreas Schwab
On Mär 28 2022, Richard Biener via Gcc-patches wrote: > OK in principle, but I have no idea on how portable > > $(libexecdir:\$(exec_prefix)/%=%) > > is going to be? We already require GNU make, don't we? > We should aim for POSIX shell compatibility here, whatever that > exactly is. It's not a

Re: [PATCH][libgomp, testsuite] Fix hardcoded libexec in plugin/configfrag.ac

2022-03-28 Thread Tom de Vries via Gcc-patches
On 3/28/22 10:49, Richard Biener wrote: On Mon, 28 Mar 2022, Tom de Vries wrote: Hi, When building an nvptx offloading configuration on openSUSE Leap 15.3, the site script /usr/share/site/x86_64-unknown-linux-gnu is activated, setting libexecdir to ${exec_prefix}/lib rather than ${exec_prefix}

Re: [PATCH][libgomp, testsuite] Fix hardcoded libexec in plugin/configfrag.ac

2022-03-28 Thread Richard Biener via Gcc-patches
On Mon, 28 Mar 2022, Tom de Vries wrote: > Hi, > > When building an nvptx offloading configuration on openSUSE Leap 15.3, the > site script /usr/share/site/x86_64-unknown-linux-gnu is activated, setting > libexecdir to ${exec_prefix}/lib rather than ${exec_prefix}/libexec: > ... > | # If user did

[PATCH][libgomp, testsuite] Fix hardcoded libexec in plugin/configfrag.ac

2022-03-28 Thread Tom de Vries via Gcc-patches
Hi, When building an nvptx offloading configuration on openSUSE Leap 15.3, the site script /usr/share/site/x86_64-unknown-linux-gnu is activated, setting libexecdir to ${exec_prefix}/lib rather than ${exec_prefix}/libexec: ... | # If user did not specify libexecdir, set the correct target: | # Nor