Re: [PATCH][gcc] libgccjit: add bitfield support

2019-07-04 Thread Andrea Corallo
Andrea Corallo writes: > Hi Dave, > last version for this patch addressing the suggestion about the > JIT_BIT_FIELD macros comment description. > > Thank you for all the suggestions. > > Regarding the write access please see my previous answer into the binary > op patch thread. > > Bests > And

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-27 Thread Andrea Corallo
Hi Dave, last version for this patch addressing the suggestion about the JIT_BIT_FIELD macros comment description. Thank you for all the suggestions. Regarding the write access please see my previous answer into the binary op patch thread. Bests Andrea 2019-06-20 Andrea Corallo andrea.cora.

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-26 Thread David Malcolm
On Wed, 2019-06-26 at 11:07 +, Andrea Corallo wrote: > Hi David, > thanks for the suggestions. > Updated version for the bitfield libgccjit support patch here > addressing comments. > > test-error-gcc_jit_context_new_bitfield-invalid-width.c is reworked > and now assume that the long of the co

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-26 Thread Andrea Corallo
Hi David, thanks for the suggestions. Updated version for the bitfield libgccjit support patch here addressing comments. test-error-gcc_jit_context_new_bitfield-invalid-width.c is reworked and now assume that the long of the compiler compiling the test is of the same size of the libgccjit long. I'

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-24 Thread David Malcolm
On Mon, 2019-06-24 at 15:26 +, Andrea Corallo wrote: > Hi all, > second version here of the gcc_jit_context_new_bitfield patch > addressing > review comments. > > Checked with make check-jit runs clean. > > Bests > > Andrea > > 2019-06-20 Andrea Corallo andrea.cora...@arm.com > > * docs/t

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-24 Thread Andrea Corallo
Hi all, second version here of the gcc_jit_context_new_bitfield patch addressing review comments. Checked with make check-jit runs clean. Bests Andrea 2019-06-20 Andrea Corallo andrea.cora...@arm.com * docs/topics/compatibility.rst (LIBGCCJIT_ABI_12): New ABI tag. * docs/topics/types.rst: Add

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-18 Thread Andrea Corallo
David Malcolm writes: > Thanks for working on this; sorry for the delay in reviewing it. > > Overall, this looks close to being ready, but I have a few notes: > > [...] Cool thanks for the review. I'll adress your comments. When you have time if you could take a look to the other pending patch

Re: [PATCH][gcc] libgccjit: add bitfield support

2019-06-18 Thread David Malcolm
On Mon, 2019-06-03 at 09:51 +, Andrea Corallo wrote: > Hi all, > I would like to submit this patch that aims to introduce bitfields > support into libgccjit. > > A new entry point gcc_jit_context_new_bitfield is added plus relative > testcase. > > Checked with make check-jit does not introduc

PING: [PATCH][gcc] libgccjit: add bitfield support

2019-06-18 Thread Andrea Corallo
Just wanted to politely ping to have have a status on that. Bests Andrea Andrea Corallo writes: > Hi all, > I would like to submit this patch that aims to introduce bitfields support > into libgccjit. > > A new entry point gcc_jit_context_new_bitfield is added plus relative > testcase. > > C

[PATCH][gcc] libgccjit: add bitfield support

2019-06-03 Thread Andrea Corallo
Hi all, I would like to submit this patch that aims to introduce bitfields support into libgccjit. A new entry point gcc_jit_context_new_bitfield is added plus relative testcase. Checked with make check-jit does not introduce regressions. Feedbacks are very welcome. Bests Andrea 2019-06-01