Re: [PATCH][debug] Fix handling of vlas in lto

2019-06-28 Thread Eric Botcazou
> 2018-08-17 Tom de Vries > > * dwarf2out.c (add_scalar_info): Don't add reference to existing die > unless the referenced die describes the added property using > DW_AT_location or DW_AT_const_value. Fall back to exprloc case. > Otherwise, add a DW_AT_location to the r

Re: [PATCH][debug] Fix handling of vlas in lto

2018-08-22 Thread Richard Biener
On Tue, 21 Aug 2018, Tom de Vries wrote: > On 08/20/2018 03:09 PM, Richard Biener wrote: > > On Fri, 17 Aug 2018, Tom de Vries wrote: > > > >> I've rewritten the patch to work generically, not just for > >> DW_AT_upper_bound, > >> and to reuse the code already there in add_scalar_info. > >> > >>

Re: [PATCH][debug] Fix handling of vlas in lto

2018-08-21 Thread Tom de Vries
On 08/20/2018 03:09 PM, Richard Biener wrote: > On Fri, 17 Aug 2018, Tom de Vries wrote: > >> I've rewritten the patch to work generically, not just for DW_AT_upper_bound, >> and to reuse the code already there in add_scalar_info. >> >> OK for trunk? >> >> Thanks, >> - Tom >> >> [debug] Fix handli

Re: [PATCH][debug] Fix handling of vlas in lto

2018-08-20 Thread Richard Biener
On Fri, 17 Aug 2018, Tom de Vries wrote: > I've rewritten the patch to work generically, not just for DW_AT_upper_bound, > and to reuse the code already there in add_scalar_info. > > OK for trunk? > > Thanks, > - Tom > > [debug] Fix handling of vlas in lto > > Atm, when running vla-1.c with -O

[PATCH][debug] Fix handling of vlas in lto

2018-08-17 Thread Tom de Vries
I've rewritten the patch to work generically, not just for DW_AT_upper_bound, and to reuse the code already there in add_scalar_info. OK for trunk? Thanks, - Tom [debug] Fix handling of vlas in lto Atm, when running vla-1.c with -O0 -flto, we have: ... FAIL: gcc.dg/guality/vla-1.c -O0 -flto -fu