Re: [PATCH][combine][1/2] Try to simplify before substituting

2015-07-20 Thread Kyrill Tkachov
On 18/07/15 17:02, Segher Boessenkool wrote: On Fri, Jul 17, 2015 at 02:47:34PM -0600, Jeff Law wrote: I mean move the whole "if (BINARY_P ..." block to after the existing simplify calls, to just before the "First see if we can apply" comment, and not do a new simplify_rtx call at all. Does th

Re: [PATCH][combine][1/2] Try to simplify before substituting

2015-07-18 Thread Segher Boessenkool
On Fri, Jul 17, 2015 at 02:47:34PM -0600, Jeff Law wrote: > >>I mean move the whole "if (BINARY_P ..." block to after the existing > >>simplify calls, to just before the "First see if we can apply" comment, > >>and not do a new simplify_rtx call at all. Does that work? > > > >Yes, and here's the p

Re: [PATCH][combine][1/2] Try to simplify before substituting

2015-07-17 Thread Jeff Law
On 07/17/2015 05:36 AM, Kyrill Tkachov wrote: On 16/07/15 19:28, Segher Boessenkool wrote: On Thu, Jul 16, 2015 at 07:17:54PM +0100, Kyrill Tkachov wrote: If you always want to simplify first, does it work to move this whole big block behind the simplify just following it? Or do you want to s

Re: [PATCH][combine][1/2] Try to simplify before substituting

2015-07-17 Thread Pinski, Andrew
> On Jul 17, 2015, at 7:36 PM, Kyrill Tkachov wrote: > > >> On 16/07/15 19:28, Segher Boessenkool wrote: >> On Thu, Jul 16, 2015 at 07:17:54PM +0100, Kyrill Tkachov wrote: If you always want to simplify first, does it work to move this whole big block behind the simplify just follo

Re: [PATCH][combine][1/2] Try to simplify before substituting

2015-07-17 Thread Kyrill Tkachov
On 16/07/15 19:28, Segher Boessenkool wrote: On Thu, Jul 16, 2015 at 07:17:54PM +0100, Kyrill Tkachov wrote: If you always want to simplify first, does it work to move this whole big block behind the simplify just following it? Or do you want to simplify after the transform as well? You mean

Re: [PATCH][combine][1/2] Try to simplify before substituting

2015-07-16 Thread Kyrill Tkachov
On 16/07/15 19:28, Segher Boessenkool wrote: On Thu, Jul 16, 2015 at 07:17:54PM +0100, Kyrill Tkachov wrote: If you always want to simplify first, does it work to move this whole big block behind the simplify just following it? Or do you want to simplify after the transform as well? You mean

Re: [PATCH][combine][1/2] Try to simplify before substituting

2015-07-16 Thread Segher Boessenkool
On Thu, Jul 16, 2015 at 07:17:54PM +0100, Kyrill Tkachov wrote: > >If you always want to simplify first, does it work to move this whole big > >block behind the simplify just following it? Or do you want to simplify > >after the transform as well? > > You mean move this hunk outside the "if (BINA

Re: [PATCH][combine][1/2] Try to simplify before substituting

2015-07-16 Thread Kyrill Tkachov
On 16/07/15 19:13, Segher Boessenkool wrote: On Thu, Jul 16, 2015 at 04:25:14PM +0100, Kyrill Tkachov wrote: Hi all, This is an attempt to solve the problem in the thread starting at https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01010.html in a generic way after some pointers from Segher and A

Re: [PATCH][combine][1/2] Try to simplify before substituting

2015-07-16 Thread Segher Boessenkool
On Thu, Jul 16, 2015 at 04:25:14PM +0100, Kyrill Tkachov wrote: > Hi all, > > This is an attempt to solve the problem in the thread starting at > https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01010.html > in a generic way after some pointers from Segher and Andrew. > > The problem I got was that

[PATCH][combine][1/2] Try to simplify before substituting

2015-07-16 Thread Kyrill Tkachov
Hi all, This is an attempt to solve the problem in the thread starting at https://gcc.gnu.org/ml/gcc-patches/2015-07/msg01010.html in a generic way after some pointers from Segher and Andrew. The problem I got was that combine_simplify_rtx was trying to do some special handling of unary operatio