Re: [PATCH][c++] Fix DECL_BY_REFERENCE of clone parms

2018-10-23 Thread Jakub Jelinek
On Tue, Oct 23, 2018 at 06:28:27PM +0200, Tom de Vries wrote: > On 7/31/18 11:22 AM, Richard Biener wrote: > > Otherwise OK for trunk and also for branches after a while. > > I just backported this fix to gcc-8-branch and gcc-7-branch. > > I noticed that the gcc-6 branch is frozen, and changes re

Re: [PATCH][c++] Fix DECL_BY_REFERENCE of clone parms

2018-10-23 Thread Tom de Vries
On 7/31/18 11:22 AM, Richard Biener wrote: > Otherwise OK for trunk and also for branches after a while. Jakub, I just backported this fix to gcc-8-branch and gcc-7-branch. I noticed that the gcc-6 branch is frozen, and changes require RM approval. Do you want this fix in gcc-6? Thanks, - Tom

Re: [PATCH][c++] Fix DECL_BY_REFERENCE of clone parms

2018-07-31 Thread Jason Merrill
OK. On Tue, Jul 31, 2018 at 7:22 PM, Richard Biener wrote: > On Mon, 30 Jul 2018, Tom de Vries wrote: > >> Hi, >> >> Consider test.C compiled at -O0 -g: >> ... >> class string { >> public: >> string (const char *p) { this->p = p ; } >> string (const string &s) { this->p = s.p; } >> >> private

Re: [PATCH][c++] Fix DECL_BY_REFERENCE of clone parms

2018-07-31 Thread Richard Biener
On Mon, 30 Jul 2018, Tom de Vries wrote: > Hi, > > Consider test.C compiled at -O0 -g: > ... > class string { > public: > string (const char *p) { this->p = p ; } > string (const string &s) { this->p = s.p; } > > private: > const char *p; > }; > > class foo { > public: > foo (string dir

[PATCH][c++] Fix DECL_BY_REFERENCE of clone parms

2018-07-30 Thread Tom de Vries
Hi, Consider test.C compiled at -O0 -g: ... class string { public: string (const char *p) { this->p = p ; } string (const string &s) { this->p = s.p; } private: const char *p; }; class foo { public: foo (string dir_hint) {} }; int main (void) { std::string s = "This is just a string";