Re: [PATCH][_GLIBCXX_DEBUG] Add basic_string::starts_with/ends_with checks

2022-08-26 Thread Jonathan Wakely via Gcc-patches
On Sun, 14 Aug 2022 at 16:34, François Dumont via Libstdc++ wrote: > > I think we can add those checks. > > Note that I wonder if it was needed as in basic_string_view I see usages > of __attribute__((__nonnull__)). But running the test I saw no impact > even after I try to apply this attribute to

Re: [PATCH][_GLIBCXX_DEBUG] Add basic_string::starts_with/ends_with checks

2022-08-15 Thread François Dumont via Gcc-patches
With the patch ! On 14/08/22 17:32, François Dumont wrote: I think we can add those checks. Note that I wonder if it was needed as in basic_string_view I see usages of __attribute__((__nonnull__)). But running the test I saw no impact even after I try to apply this attribute to the starts_wi

[PATCH][_GLIBCXX_DEBUG] Add basic_string::starts_with/ends_with checks

2022-08-14 Thread François Dumont via Gcc-patches
I think we can add those checks. Note that I wonder if it was needed as in basic_string_view I see usages of __attribute__((__nonnull__)). But running the test I saw no impact even after I try to apply this attribute to the starts_with/ends_with methods themselves. Also note that several che