Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-12-03 Thread Jeff Law via Gcc-patches
On 11/29/2021 4:51 PM, Navid Rahimi wrote: Jeff, Sorry for bringing back this thread. Quick question, you mentioned checking the TYPE_PRECISION to make sure the type is a canonical Boolean type (and not a fancy signed/unsigned Boolean type from Ada Andrew mentioned). But I noticed that tru

Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-29 Thread Navid Rahimi via Gcc-patches
om: Jeff Law Sent: Tuesday, November 23, 2021 12:03 To: Navid Rahimi; Andrew Pinski Cc: Navid Rahimi via Gcc-patches Subject: Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification On 11/23/2021 12:55 PM, Navid Rahimi wrote: >> Did you test Ada with

Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-23 Thread Jeff Law via Gcc-patches
On 11/23/2021 1:08 PM, Navid Rahimi wrote: In gimple your primary goal should be to reduce the number of expressions that are evaluated. This patch does the opposite. That is actually a really good point in my opinion. I am hesitant about this patch and wanted to hear gcc-patch opinion abou

Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-23 Thread Navid Rahimi via Gcc-patches
:02 To: Navid Rahimi; Navid Rahimi via Gcc-patches Subject: Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification On 11/23/2021 12:42 PM, Navid Rahimi wrote: > In case of x86_64. This is the code: > > src_1(bool, bool): > cmp dil, s

Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-23 Thread Jeff Law via Gcc-patches
On 11/23/2021 12:55 PM, Navid Rahimi wrote: Did you test Ada with this patch as that is where the "odd" boolean types show up? No I haven't tested Ada yet. Since it is work in progress still [WIP]. Quick question, to prevent applying this optimization to those odd Boolean types in Ada, ther

Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-23 Thread Jeff Law via Gcc-patches
On 11/23/2021 12:42 PM, Navid Rahimi wrote: In case of x86_64. This is the code: src_1(bool, bool): cmp dil, sil setbal ret tgt_1(bool, bool): xor edi, 1 mov eax, edi and eax, esi ret Lets look at the latenc

Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-23 Thread Navid Rahimi via Gcc-patches
a Gcc-patches Subject: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification [You don't often get email from pins...@gmail.com. Learn why this is important at http://aka.ms/LearnAboutSenderIdentification.] On Tue, Nov 23, 2021 at 11:15 AM Jeff Law via Gcc-patche

Re: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-23 Thread Navid Rahimi via Gcc-patches
tures-optimization-manual.pdf Best wishes, Navid. From: Jeff Law Sent: Tuesday, November 23, 2021 11:14 To: Navid Rahimi; Navid Rahimi via Gcc-patches Subject: [EXTERNAL] Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification On 11/23/20

Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-23 Thread Andrew Pinski via Gcc-patches
On Tue, Nov 23, 2021 at 11:15 AM Jeff Law via Gcc-patches wrote: > > > > On 11/23/2021 11:34 AM, Navid Rahimi via Gcc-patches wrote: > > Hi GCC community, > > > > I wanted you take a quick look at this patch to solve this bug [1]. This is > > the code example for the optimization [2] which does i

Re: [PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-23 Thread Jeff Law via Gcc-patches
On 11/23/2021 11:34 AM, Navid Rahimi via Gcc-patches wrote: Hi GCC community, I wanted you take a quick look at this patch to solve this bug [1]. This is the code example for the optimization [2] which does include a link to proof of each different optimization. I think it should be possib

[PATCH][WIP] PR tree-optimization/101808 Boolean comparison simplification

2021-11-23 Thread Navid Rahimi via Gcc-patches
Hi GCC community, I wanted you take a quick look at this patch to solve this bug [1]. This is the code example for the optimization [2] which does include a link to proof of each different optimization. I think it should be possible to use simpler approach than what Andrew has used here [3].