Re: [PATCH][Revisedx5] Enable libsanitizer on darwin

2012-11-23 Thread Konstantin Serebryany
Looks great. (I am not an expert in the build system either, but the changes look trivial). Thanks! --kcc On Fri, Nov 23, 2012 at 8:29 PM, Alexander Potapenko wrote: > The mach_override path looks good to me. I don't have enough knowledge > of GCC buildsystem yet to review the rest. > > On Fri,

Re: [PATCH][Revisedx5] Enable libsanitizer on darwin

2012-11-23 Thread Alexander Potapenko
The mach_override path looks good to me. I don't have enough knowledge of GCC buildsystem yet to review the rest. On Fri, Nov 23, 2012 at 8:17 PM, Jack Howarth wrote: >The attached patch imports the missing mach_override/mach_override.h and > mach_override/mach_override.c files from llvm.org'

[PATCH][Revisedx5] Enable libsanitizer on darwin

2012-11-23 Thread Jack Howarth
The attached patch imports the missing mach_override/mach_override.h and mach_override/mach_override.c files from llvm.org's compiler-rt at r168032 | glider | 2012-11-15 03:32:16 -0500 (Thu, 15 Nov 2012) | 3 lines [ASan] Add the "lea $imm(%rip),%rax" instruction to mach_override.c The need fo