Re: Porting libsanitizer to Solaris (Was: Re: [PATCH][Revised] Enable libsanitizer on darwin)

2014-07-04 Thread Konstantin Serebryany
Hi Rainer, All contributions to libsanitizer should go via LLVM repository. See https://code.google.com/p/address-sanitizer/wiki/HowToContribute The smaller the patches the faster they will come through. If you can set up a public build bot it will *immensely* simplify many things. (see more below

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-15 Thread Rainer Orth
Hi Alex, >> thanks, that's certainly helpful. I'm primarily interested in porting >> to Solaris, both SPARC and x86. Several things should be similar to >> Linux (both being ELF systems), while other areas are certainly >> different (syscalls implementation etc.). > We don't wrap the syscalls in

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-15 Thread Dodji Seketeli
Maybe Konstantin could Help with the review, as this touches libsanitizer? Cheers. Mike Stump writes: > On Nov 14, 2012, at 6:43 AM, Jack Howarth wrote: >> The attached patch assumes that mach_override/mach_override.h >> and mach_override/mach_override.c has been imported by the libsanitizer

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Jack Howarth
On Wed, Nov 14, 2012 at 10:54:18AM -0800, Mike Stump wrote: > On Nov 14, 2012, at 6:43 AM, Jack Howarth wrote: > > The attached patch assumes that mach_override/mach_override.h > > and mach_override/mach_override.c has been imported by the libsanitizer > > maintainers for use by darwin. > > So,

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Mike Stump
On Nov 14, 2012, at 6:43 AM, Jack Howarth wrote: > The attached patch assumes that mach_override/mach_override.h > and mach_override/mach_override.c has been imported by the libsanitizer > maintainers for use by darwin. So, the patches are a nice start. Since we are in stage3, they need to go

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Alexander Potapenko
I've responded to the bug. Sorry for offtopics unrelated to your original patch. On Wed, Nov 14, 2012 at 8:11 PM, Jack Howarth wrote: > On Wed, Nov 14, 2012 at 07:56:18PM +0400, Alexander Potapenko wrote: >> Hi Rainer, >> >> The quick answer is no, although the expansion into GCC world may >> req

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Alexander Potapenko
On Wed, Nov 14, 2012 at 8:09 PM, Rainer Orth wrote: > Hi Alex, > > thanks, that's certainly helpful. I'm primarily interested in porting > to Solaris, both SPARC and x86. Several things should be similar to > Linux (both being ELF systems), while other areas are certainly > different (syscalls

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Jack Howarth
On Wed, Nov 14, 2012 at 07:56:18PM +0400, Alexander Potapenko wrote: > Hi Rainer, > > The quick answer is no, although the expansion into GCC world may > require such a guideline. > We've initially implemented ASan on Linux and then ported it to > Android (which is very similar to Linux) and Mac (

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Rainer Orth
Hi Alex, > The quick answer is no, although the expansion into GCC world may > require such a guideline. > We've initially implemented ASan on Linux and then ported it to > Android (which is very similar to Linux) and Mac (which is very > different), so we have little experience with porting yet.

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Alexander Potapenko
Hi Rainer, The quick answer is no, although the expansion into GCC world may require such a guideline. We've initially implemented ASan on Linux and then ported it to Android (which is very similar to Linux) and Mac (which is very different), so we have little experience with porting yet. I've sum

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Rainer Orth
Jack Howarth writes: >I am confused on the strategy here. Will the FSF gcc developers be > prohibiting > the addition of darwin support for libsanitizer until all issues in its > operation > are resolved? It seems like a chicken and egg situation. I think this should > be > considered an e

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Jack Howarth
On Wed, Nov 14, 2012 at 04:08:06PM +0100, Rainer Orth wrote: > Hi Alex, > > > most certainly the functionality of asan is not intact. > > The error messages denote that mach_override couldn't parse some of > > the function prologues, which means some of ASan interceptors just > > won't work. > > I

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Jack Howarth
On Wed, Nov 14, 2012 at 07:00:14PM +0400, Alexander Potapenko wrote: > Hi Jack, > > most certainly the functionality of asan is not intact. > The error messages denote that mach_override couldn't parse some of > the function prologues, which means some of ASan interceptors just > won't work. > In

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Rainer Orth
Hi Alex, > most certainly the functionality of asan is not intact. > The error messages denote that mach_override couldn't parse some of > the function prologues, which means some of ASan interceptors just > won't work. > In order to fix this you need to change the DEBUG definition in > mach_overr

Re: [PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Alexander Potapenko
Hi Jack, most certainly the functionality of asan is not intact. The error messages denote that mach_override couldn't parse some of the function prologues, which means some of ASan interceptors just won't work. In order to fix this you need to change the DEBUG definition in mach_override.c, look

[PATCH][Revised] Enable libsanitizer on darwin

2012-11-14 Thread Jack Howarth
The attached patch assumes that mach_override/mach_override.h and mach_override/mach_override.c has been imported by the libsanitizer maintainers for use by darwin. The patch adds darwin to the supported target list in configure.tgt and defines USING_MACH_OVERRIDE for darwin in configure.ac. The