RE: [PATCH][RX] Patch to correct the functionality of compiler option -falign-labels=n

2014-06-12 Thread Sandeep Kumar Singh
Hi DJ, > Have you checked the other alignment macros to see if they need to be > fixed too? Thank you for review this patch. Yes, I have checked other alignment macros and it seems fine. > This should be : I have corrected this review comment. Is this patch now ok to commit? Best Regards, Sand

Re: [PATCH][RX] Patch to correct the functionality of compiler option -falign-labels=n

2014-06-11 Thread DJ Delorie
> Please review the patch and let me know if there should be any modifications > in it? Have you checked the other alignment macros to see if they need to be fixed too? * config/rx/rx.h (Corrected macro LABEL_ALIGN). This should be : * config/rx/rx.h (LABEL_ALIGN): It's alway

[PATCH][RX] Patch to correct the functionality of compiler option -falign-labels=n

2014-06-11 Thread Sandeep Kumar Singh
Hi, The RX compiler align wrong labels with option falign-labels=n, where n is number of bytes. The relationship between -falign-labels and expected .balign output supposed to be: -falign-labels=4 --> .balign 4 -falign-labels=8 --> .balign 8 -falign-labels=16 --> .balign 16 However, listed pse