Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-11-09 Thread Teresa Johnson
Ok, thanks. Will do, with appropriate credit. =) Teresa On Fri, Nov 9, 2012 at 12:12 PM, Steven Bosscher wrote: > Hello Teresa, > > It seems to me that it's better if you commit it along with your set > of fixes. My patch doesn't fix any bugs, it just exposes them :-) > > Ciao! > Steven > > > > O

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-11-09 Thread Steven Bosscher
Hello Teresa, It seems to me that it's better if you commit it along with your set of fixes. My patch doesn't fix any bugs, it just exposes them :-) Ciao! Steven On Fri, Nov 9, 2012 at 9:09 PM, Teresa Johnson wrote: > > Hi Steven, > > I've spent this week trying to clean up all the issues exp

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-11-01 Thread Matthew Gretton-Dann
On 31 October 2012 20:06, Teresa Johnson wrote: > On Wed, Oct 31, 2012 at 12:58 PM, Christophe Lyon > wrote: >> On 30.10.2012 17:59, Teresa Johnson wrote: >>> >>> On Tue, Oct 30, 2012 at 9:26 AM, Steven Bosscher >>> wrote: Hello, Hot/cold partitioning is apparently a hot topi

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-31 Thread Teresa Johnson
On Wed, Oct 31, 2012 at 12:58 PM, Christophe Lyon wrote: > On 30.10.2012 17:59, Teresa Johnson wrote: >> >> On Tue, Oct 30, 2012 at 9:26 AM, Steven Bosscher >> wrote: >>> >>> Hello, >>> >>> Hot/cold partitioning is apparently a hot topic all of a sudden, which >>> is a good thing of course, becau

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-31 Thread Christophe Lyon
On 30.10.2012 17:59, Teresa Johnson wrote: On Tue, Oct 30, 2012 at 9:26 AM, Steven Bosscher wrote: Hello, Hot/cold partitioning is apparently a hot topic all of a sudden, which is a good thing of course, because it's in need of some TLC. The attached patch adds another check the RTL cfg check

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Teresa Johnson
On Tue, Oct 30, 2012 at 2:31 PM, Teresa Johnson wrote: > On Tue, Oct 30, 2012 at 12:33 PM, Xinliang David Li > wrote: >> On Tue, Oct 30, 2012 at 12:25 PM, Steven Bosscher >> wrote: >>> On Tue, Oct 30, 2012 at 5:59 PM, Teresa Johnson wrote: I will try testing your patch on top of mine with

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Steven Bosscher
On Tue, Oct 30, 2012 at 10:31 PM, Teresa Johnson wrote: > In an attempt to provoke the failures I was seeing on a smaller test > case, I tried enabling -freorder-blocks-and-partition by default in my > common.opt file and running through the regression test suite (without > my fixes). But I didn't

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Xinliang David Li
There are not many -- see gcc/testsuite/gcc.dg/tree-prof directory. Under that, 5 cases explicitly set the option. David On Tue, Oct 30, 2012 at 2:31 PM, Teresa Johnson wrote: > On Tue, Oct 30, 2012 at 12:33 PM, Xinliang David Li > wrote: >> On Tue, Oct 30, 2012 at 12:25 PM, Steven Bosscher

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Teresa Johnson
On Tue, Oct 30, 2012 at 12:33 PM, Xinliang David Li wrote: > On Tue, Oct 30, 2012 at 12:25 PM, Steven Bosscher > wrote: >> On Tue, Oct 30, 2012 at 5:59 PM, Teresa Johnson wrote: >>> I will try testing your patch on top of mine with our fdo benchmarks. >> >> Thanks. But you should expect a lot of

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Xinliang David Li
On Tue, Oct 30, 2012 at 12:25 PM, Steven Bosscher wrote: > On Tue, Oct 30, 2012 at 5:59 PM, Teresa Johnson wrote: >> I will try testing your patch on top of mine with our fdo benchmarks. > > Thanks. But you should expect a lot of errors, hopefully you can make > something out of it for Bugzilla. >

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Steven Bosscher
On Tue, Oct 30, 2012 at 5:59 PM, Teresa Johnson wrote: > I will try testing your patch on top of mine with our fdo benchmarks. Thanks. But you should expect a lot of errors, hopefully you can make something out of it for Bugzilla. > For the others on the cc list, you may need to include my patch

Re: [PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Teresa Johnson
On Tue, Oct 30, 2012 at 9:26 AM, Steven Bosscher wrote: > Hello, > > Hot/cold partitioning is apparently a hot topic all of a sudden, which > is a good thing of course, because it's in need of some TLC. > > The attached patch adds another check the RTL cfg checking > (verify_flow_info) for the par

[PATCH][RFC] Sanity checking for -freorder-blocks-and-partition failures

2012-10-30 Thread Steven Bosscher
Hello, Hot/cold partitioning is apparently a hot topic all of a sudden, which is a good thing of course, because it's in need of some TLC. The attached patch adds another check the RTL cfg checking (verify_flow_info) for the partitioning: A hot block can never be dominated by a cold block (becaus