Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-25 Thread Richard Biener
On Tue, Jun 25, 2019 at 12:25 PM Martin Liška wrote: > > On 6/24/19 4:09 PM, Richard Biener wrote: > > You still get one instance in each TU ... > > Right, fixed in attached patch. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? Yes. Thanks,

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-25 Thread Martin Liška
On 6/25/19 12:25 PM, Martin Liška wrote: > On 6/24/19 4:09 PM, Richard Biener wrote: >> You still get one instance in each TU ... > > Right, fixed in attached patch. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Thanks, > Martin > Btw.

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-25 Thread Martin Liška
On 6/24/19 4:09 PM, Richard Biener wrote: > You still get one instance in each TU ... Right, fixed in attached patch. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Thanks, Martin >From aa5ea14a8665b14aa60245c42bd4c9809d0bf81a Mon Sep 17 00:00:00 20

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-24 Thread Richard Biener
On Mon, Jun 24, 2019 at 3:51 PM Martin Liška wrote: > > On 6/24/19 2:29 PM, Richard Biener wrote: > > On Mon, Jun 24, 2019 at 1:08 AM Ian Lance Taylor wrote: > >> > >> On Fri, Jun 7, 2019 at 5:04 AM Martin Liška wrote: > >>> > >>> On 6/7/19 10:57 AM, Richard Biener wrote: > On Mon, Jun 3, 2

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-24 Thread Martin Liška
On 6/24/19 2:29 PM, Richard Biener wrote: > On Mon, Jun 24, 2019 at 1:08 AM Ian Lance Taylor wrote: >> >> On Fri, Jun 7, 2019 at 5:04 AM Martin Liška wrote: >>> >>> On 6/7/19 10:57 AM, Richard Biener wrote: On Mon, Jun 3, 2019 at 3:35 PM Martin Liška wrote: > > On 6/1/19 12:06 AM, J

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-24 Thread Richard Biener
On Mon, Jun 24, 2019 at 1:08 AM Ian Lance Taylor wrote: > > On Fri, Jun 7, 2019 at 5:04 AM Martin Liška wrote: > > > > On 6/7/19 10:57 AM, Richard Biener wrote: > > > On Mon, Jun 3, 2019 at 3:35 PM Martin Liška wrote: > > >> > > >> On 6/1/19 12:06 AM, Jeff Law wrote: > > >>> On 5/22/19 3:13 AM,

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-23 Thread Ian Lance Taylor
On Fri, Jun 7, 2019 at 5:04 AM Martin Liška wrote: > > On 6/7/19 10:57 AM, Richard Biener wrote: > > On Mon, Jun 3, 2019 at 3:35 PM Martin Liška wrote: > >> > >> On 6/1/19 12:06 AM, Jeff Law wrote: > >>> On 5/22/19 3:13 AM, Martin Liška wrote: > On 5/21/19 1:51 PM, Richard Biener wrote: > >>

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-12 Thread Martin Liška
On 6/12/19 2:50 PM, Richard Biener wrote: > New params should always go to the end Ah, sorry, I'll take of that new time. I've just changed the function signature and I can verify there are no other calls (tested for --enable-languages=all). Thanks, Martin

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-12 Thread Richard Biener
On Wed, Jun 12, 2019 at 1:45 PM Martin Liška wrote: > > On 6/12/19 11:41 AM, Richard Biener wrote: > > On Wed, Jun 12, 2019 at 11:15 AM Martin Liška wrote: > >> > >> On 6/12/19 10:02 AM, Martin Liška wrote: > >>> On 6/12/19 9:59 AM, Richard Biener wrote: > On Tue, Jun 11, 2019 at 9:02 PM Jas

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-12 Thread Martin Liška
On 6/12/19 11:41 AM, Richard Biener wrote: > On Wed, Jun 12, 2019 at 11:15 AM Martin Liška wrote: >> >> On 6/12/19 10:02 AM, Martin Liška wrote: >>> On 6/12/19 9:59 AM, Richard Biener wrote: On Tue, Jun 11, 2019 at 9:02 PM Jason Merrill wrote: > > On 6/11/19 9:16 AM, Martin Liška wro

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-12 Thread Richard Biener
On Wed, Jun 12, 2019 at 11:15 AM Martin Liška wrote: > > On 6/12/19 10:02 AM, Martin Liška wrote: > > On 6/12/19 9:59 AM, Richard Biener wrote: > >> On Tue, Jun 11, 2019 at 9:02 PM Jason Merrill wrote: > >>> > >>> On 6/11/19 9:16 AM, Martin Liška wrote: > On 6/11/19 2:27 PM, Jason Merrill wr

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-12 Thread Martin Liška
On 6/12/19 10:02 AM, Martin Liška wrote: > On 6/12/19 9:59 AM, Richard Biener wrote: >> On Tue, Jun 11, 2019 at 9:02 PM Jason Merrill wrote: >>> >>> On 6/11/19 9:16 AM, Martin Liška wrote: On 6/11/19 2:27 PM, Jason Merrill wrote: > On 6/11/19 3:41 AM, Martin Liška wrote: >> On 6/10/19

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-12 Thread Martin Liška
On 6/12/19 9:59 AM, Richard Biener wrote: > On Tue, Jun 11, 2019 at 9:02 PM Jason Merrill wrote: >> >> On 6/11/19 9:16 AM, Martin Liška wrote: >>> On 6/11/19 2:27 PM, Jason Merrill wrote: On 6/11/19 3:41 AM, Martin Liška wrote: > On 6/10/19 8:21 PM, Jason Merrill wrote: >> On Mon, Jun

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-12 Thread Richard Biener
On Tue, Jun 11, 2019 at 9:02 PM Jason Merrill wrote: > > On 6/11/19 9:16 AM, Martin Liška wrote: > > On 6/11/19 2:27 PM, Jason Merrill wrote: > >> On 6/11/19 3:41 AM, Martin Liška wrote: > >>> On 6/10/19 8:21 PM, Jason Merrill wrote: > On Mon, Jun 10, 2019 at 3:08 AM Martin Liška wrote: > >>

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-11 Thread Jason Merrill
On 6/11/19 9:16 AM, Martin Liška wrote: On 6/11/19 2:27 PM, Jason Merrill wrote: On 6/11/19 3:41 AM, Martin Liška wrote: On 6/10/19 8:21 PM, Jason Merrill wrote: On Mon, Jun 10, 2019 at 3:08 AM Martin Liška wrote: On 6/7/19 11:43 PM, Jason Merrill wrote: On Fri, Jun 7, 2019 at 8:14 AM Marti

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-11 Thread Martin Liška
On 6/11/19 2:27 PM, Jason Merrill wrote: > On 6/11/19 3:41 AM, Martin Liška wrote: >> On 6/10/19 8:21 PM, Jason Merrill wrote: >>> On Mon, Jun 10, 2019 at 3:08 AM Martin Liška wrote: On 6/7/19 11:43 PM, Jason Merrill wrote: > On Fri, Jun 7, 2019 at 8:14 AM Martin Liška wrote: >> On 6

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-11 Thread Jason Merrill
On 6/11/19 3:41 AM, Martin Liška wrote: On 6/10/19 8:21 PM, Jason Merrill wrote: On Mon, Jun 10, 2019 at 3:08 AM Martin Liška wrote: On 6/7/19 11:43 PM, Jason Merrill wrote: On Fri, Jun 7, 2019 at 8:14 AM Martin Liška wrote: On 6/7/19 2:09 PM, Richard Biener wrote: On Fri, Jun 7, 2019 at 2

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-11 Thread Martin Liška
On 6/10/19 8:21 PM, Jason Merrill wrote: > On Mon, Jun 10, 2019 at 3:08 AM Martin Liška wrote: >> On 6/7/19 11:43 PM, Jason Merrill wrote: >>> On Fri, Jun 7, 2019 at 8:14 AM Martin Liška wrote: On 6/7/19 2:09 PM, Richard Biener wrote: > On Fri, Jun 7, 2019 at 2:03 PM Martin Liška wrote:

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-10 Thread Jason Merrill
On Mon, Jun 10, 2019 at 3:08 AM Martin Liška wrote: > On 6/7/19 11:43 PM, Jason Merrill wrote: > > On Fri, Jun 7, 2019 at 8:14 AM Martin Liška wrote: > >> On 6/7/19 2:09 PM, Richard Biener wrote: > >>> On Fri, Jun 7, 2019 at 2:03 PM Martin Liška wrote: > On 6/7/19 10:57 AM, Richard Biener w

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-10 Thread Martin Liška
On 6/7/19 11:43 PM, Jason Merrill wrote: > On Fri, Jun 7, 2019 at 8:14 AM Martin Liška wrote: >> >> On 6/7/19 2:09 PM, Richard Biener wrote: >>> On Fri, Jun 7, 2019 at 2:03 PM Martin Liška wrote: On 6/7/19 10:57 AM, Richard Biener wrote: > On Mon, Jun 3, 2019 at 3:35 PM Martin Liška

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-07 Thread Jason Merrill
On Fri, Jun 7, 2019 at 8:14 AM Martin Liška wrote: > > On 6/7/19 2:09 PM, Richard Biener wrote: > > On Fri, Jun 7, 2019 at 2:03 PM Martin Liška wrote: > >> > >> On 6/7/19 10:57 AM, Richard Biener wrote: > >>> On Mon, Jun 3, 2019 at 3:35 PM Martin Liška wrote: > > On 6/1/19 12:06 AM, Je

Re: [PATCH] Fix bootstrap (was: Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.)

2019-06-07 Thread Martin Liška
On 6/7/19 5:13 PM, Jakub Jelinek wrote: Ok for trunk? Which one? Thank you Jakub for the fix. I'm fine with both. Martin

[PATCH] Fix bootstrap (was: Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.)

2019-06-07 Thread Jakub Jelinek
Hi! Attached are two different fixes, each of which fixes the build. The first one arranges gencondmd to be linked against build/errors.o, so that it links fine, the second one instead doesn't define the function and method which requires that, as it is only called from #if CHECKING_P guarded code

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-07 Thread Martin Sebor
On 6/7/19 6:13 AM, Martin Liška wrote: On 6/7/19 2:09 PM, Richard Biener wrote: On Fri, Jun 7, 2019 at 2:03 PM Martin Liška wrote: On 6/7/19 10:57 AM, Richard Biener wrote: On Mon, Jun 3, 2019 at 3:35 PM Martin Liška wrote: On 6/1/19 12:06 AM, Jeff Law wrote: On 5/22/19 3:13 AM, Martin L

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-07 Thread Martin Liška
On 6/7/19 2:09 PM, Richard Biener wrote: > On Fri, Jun 7, 2019 at 2:03 PM Martin Liška wrote: >> >> On 6/7/19 10:57 AM, Richard Biener wrote: >>> On Mon, Jun 3, 2019 at 3:35 PM Martin Liška wrote: On 6/1/19 12:06 AM, Jeff Law wrote: > On 5/22/19 3:13 AM, Martin Liška wrote: >> O

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-07 Thread Richard Biener
On Fri, Jun 7, 2019 at 2:03 PM Martin Liška wrote: > > On 6/7/19 10:57 AM, Richard Biener wrote: > > On Mon, Jun 3, 2019 at 3:35 PM Martin Liška wrote: > >> > >> On 6/1/19 12:06 AM, Jeff Law wrote: > >>> On 5/22/19 3:13 AM, Martin Liška wrote: > On 5/21/19 1:51 PM, Richard Biener wrote: > >>

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-07 Thread Martin Liška
On 6/7/19 10:57 AM, Richard Biener wrote: > On Mon, Jun 3, 2019 at 3:35 PM Martin Liška wrote: >> >> On 6/1/19 12:06 AM, Jeff Law wrote: >>> On 5/22/19 3:13 AM, Martin Liška wrote: On 5/21/19 1:51 PM, Richard Biener wrote: > On Tue, May 21, 2019 at 1:02 PM Martin Liška wrote: >>

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-07 Thread Richard Biener
On Mon, Jun 3, 2019 at 3:35 PM Martin Liška wrote: > > On 6/1/19 12:06 AM, Jeff Law wrote: > > On 5/22/19 3:13 AM, Martin Liška wrote: > >> On 5/21/19 1:51 PM, Richard Biener wrote: > >>> On Tue, May 21, 2019 at 1:02 PM Martin Liška wrote: > > On 5/21/19 11:38 AM, Richard Biener wrote:

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-06-03 Thread Martin Liška
On 6/1/19 12:06 AM, Jeff Law wrote: > On 5/22/19 3:13 AM, Martin Liška wrote: >> On 5/21/19 1:51 PM, Richard Biener wrote: >>> On Tue, May 21, 2019 at 1:02 PM Martin Liška wrote: On 5/21/19 11:38 AM, Richard Biener wrote: > On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: >> >>>

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-31 Thread Jeff Law
On 5/22/19 3:13 AM, Martin Liška wrote: > On 5/21/19 1:51 PM, Richard Biener wrote: >> On Tue, May 21, 2019 at 1:02 PM Martin Liška wrote: >>> >>> On 5/21/19 11:38 AM, Richard Biener wrote: On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: > > On 5/13/19 1:41 AM, Martin Liška wrote: >

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-31 Thread Martin Liška
On 5/31/19 2:50 PM, Richard Biener wrote: > On Wed, May 22, 2019 at 11:13 AM Martin Liška wrote: >> >> On 5/21/19 1:51 PM, Richard Biener wrote: >>> On Tue, May 21, 2019 at 1:02 PM Martin Liška wrote: On 5/21/19 11:38 AM, Richard Biener wrote: > On Tue, May 21, 2019 at 12:07 AM Jeff

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-31 Thread Richard Biener
On Wed, May 22, 2019 at 11:13 AM Martin Liška wrote: > > On 5/21/19 1:51 PM, Richard Biener wrote: > > On Tue, May 21, 2019 at 1:02 PM Martin Liška wrote: > >> > >> On 5/21/19 11:38 AM, Richard Biener wrote: > >>> On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: > > On 5/13/19 1:41 AM,

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-22 Thread Martin Liška
On 5/21/19 1:51 PM, Richard Biener wrote: > On Tue, May 21, 2019 at 1:02 PM Martin Liška wrote: >> >> On 5/21/19 11:38 AM, Richard Biener wrote: >>> On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: On 5/13/19 1:41 AM, Martin Liška wrote: > On 11/8/18 9:56 AM, Martin Liška wrote: >>>

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-21 Thread Richard Biener
On Tue, May 21, 2019 at 1:02 PM Martin Liška wrote: > > On 5/21/19 11:38 AM, Richard Biener wrote: > > On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: > >> > >> On 5/13/19 1:41 AM, Martin Liška wrote: > >>> On 11/8/18 9:56 AM, Martin Liška wrote: > On 11/7/18 11:23 PM, Jeff Law wrote: > >>>

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-21 Thread Martin Liška
On 5/21/19 11:38 AM, Richard Biener wrote: > On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: >> >> On 5/13/19 1:41 AM, Martin Liška wrote: >>> On 11/8/18 9:56 AM, Martin Liška wrote: On 11/7/18 11:23 PM, Jeff Law wrote: > On 10/30/18 6:28 AM, Martin Liška wrote: >> On 10/30/18 11:03

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-21 Thread Richard Biener
On Tue, May 21, 2019 at 12:07 AM Jeff Law wrote: > > On 5/13/19 1:41 AM, Martin Liška wrote: > > On 11/8/18 9:56 AM, Martin Liška wrote: > >> On 11/7/18 11:23 PM, Jeff Law wrote: > >>> On 10/30/18 6:28 AM, Martin Liška wrote: > On 10/30/18 11:03 AM, Jakub Jelinek wrote: > > On Mon, Oct 29

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-20 Thread Jeff Law
On 5/13/19 1:41 AM, Martin Liška wrote: > On 11/8/18 9:56 AM, Martin Liška wrote: >> On 11/7/18 11:23 PM, Jeff Law wrote: >>> On 10/30/18 6:28 AM, Martin Liška wrote: On 10/30/18 11:03 AM, Jakub Jelinek wrote: > On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: >> +hashtab_

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-20 Thread Jason Merrill
On 5/13/19 3:41 AM, Martin Liška wrote: On 11/8/18 9:56 AM, Martin Liška wrote: On 11/7/18 11:23 PM, Jeff Law wrote: On 10/30/18 6:28 AM, Martin Liška wrote: On 10/30/18 11:03 AM, Jakub Jelinek wrote: On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: +hashtab_chk_error () +{ + f

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2019-05-13 Thread Martin Liška
On 11/8/18 9:56 AM, Martin Liška wrote: > On 11/7/18 11:23 PM, Jeff Law wrote: >> On 10/30/18 6:28 AM, Martin Liška wrote: >>> On 10/30/18 11:03 AM, Jakub Jelinek wrote: On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: > +hashtab_chk_error () > +{ > + fprintf (stderr,

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-11-08 Thread Martin Liška
On 11/7/18 11:23 PM, Jeff Law wrote: > On 10/30/18 6:28 AM, Martin Liška wrote: >> On 10/30/18 11:03 AM, Jakub Jelinek wrote: >>> On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: +hashtab_chk_error () +{ + fprintf (stderr, "hash table checking failed: " + "equa

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-11-07 Thread Jakub Jelinek
On Wed, Nov 07, 2018 at 03:23:55PM -0700, Jeff Law wrote: > > @@ -882,8 +883,12 @@ hash_table > >if (insert == INSERT && m_size * 3 <= m_n_elements * 4) > > expand (); > > > > - m_searches++; > > +#if ENABLE_EXTRA_CHECKING > > +if (insert == INSERT) > > + verify (comparable, ha

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-11-07 Thread Jeff Law
On 10/30/18 6:28 AM, Martin Liška wrote: > On 10/30/18 11:03 AM, Jakub Jelinek wrote: >> On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: >>> +hashtab_chk_error () >>> +{ >>> + fprintf (stderr, "hash table checking failed: " >>> + "equal operator returns true for a pair " >>> +

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-30 Thread Martin Liška
On 10/30/18 11:03 AM, Jakub Jelinek wrote: > On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: >> +hashtab_chk_error () >> +{ >> + fprintf (stderr, "hash table checking failed: " >> + "equal operator returns true for a pair " >> + "of values with a different hash value"); >

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-30 Thread Jakub Jelinek
On Mon, Oct 29, 2018 at 04:14:21PM +0100, Martin Liška wrote: > +hashtab_chk_error () > +{ > + fprintf (stderr, "hash table checking failed: " > +"equal operator returns true for a pair " > +"of values with a different hash value"); BTW, either use internal_error here, or at least

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-29 Thread Martin Liška
On 10/29/18 2:53 PM, Alexander Monakov wrote: > On Mon, 29 Oct 2018, Martin Liška wrote: >> My question is whether we want to have in GCC 9 time frame or should I wait >> with that? >> Does it worth implementing? > > This is cool, thanks! A few questions/comments on the patch. Hi. Thanks for su

Re: [PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-29 Thread Alexander Monakov
On Mon, 29 Oct 2018, Martin Liška wrote: > My question is whether we want to have in GCC 9 time frame or should I wait > with that? > Does it worth implementing? This is cool, thanks! A few questions/comments on the patch. I think there are places that use libiberty C-style hashtab (htab_t), wou

[PATCH][RFC] Sanitize equals and hash functions in hash-tables.

2018-10-29 Thread Martin Liška
Hi. As slightly discussed here: https://gcc.gnu.org/ml/gcc-patches/2018-10/msg01674.html I fixed a situation where an equal operator of a hash table returns true, while corresponding hash value of a pair of elements is different. That's inconsistent and can probably cause issues in different ar