Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

Hi Martin, I would change "among" to "between" in the sentence below. OK otherwise (not that I think an OK is really needed in this case). + The purpose of the directive is to provide an API among the GCC compiler and +the GNU C Library which would define vector implementations of math rou

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 2/20/19 10:36 AM, Thomas König wrote: > Hi Martin, > >> Thank you both useful comments! I installed that as r269035. > > Excellent work, thanks! ;) > > Now a final step: Could you also add a short sentence to gcc-9/changes.html ? > In German, we have a saying „Tue Gutes und rede darüber“,

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 2/20/19 11:45 AM, Bernhard Reutner-Fischer wrote: > On 20 February 2019 10:57:29 CET, "Martin Liška" wrote: >> On 2/20/19 10:52 AM, Bernhard Reutner-Fischer wrote: >>> Marin, >>> >>> + >>> +@smallexample >>> +!GCC$ builtin (sinf) attributes simd (notinbranch) if('x86_64') >>> +@

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 20 February 2019 10:57:29 CET, "Martin Liška" wrote: >On 2/20/19 10:52 AM, Bernhard Reutner-Fischer wrote: >> Marin, >> >> + >> +@smallexample >> +!GCC$ builtin (sinf) attributes simd (notinbranch) if('x86_64') >> +@end smallexample >> + >> +The purpose of the directive

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 2/20/19 10:52 AM, Bernhard Reutner-Fischer wrote: > Marin, > > + > +@smallexample > +!GCC$ builtin (sinf) attributes simd (notinbranch) if('x86_64') > +@end smallexample > + > +The purpose of the directive is to provide an API among the GCC compiler and > +the G

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

Marin, > >>> + > >>> +@smallexample > >>> +!GCC$ builtin (sinf) attributes simd (notinbranch) if('x86_64') > >>> +@end smallexample > >>> + > >>> +The purpose of the directive is to provide an API among the GCC > >> compiler and > >>> +the GNU C Library which would define vector implementation of

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

Hi Martin, > Thank you both useful comments! I installed that as r269035. Excellent work, thanks! Now a final step: Could you also add a short sentence to gcc-9/changes.html ? In German, we have a saying „Tue Gutes und rede darüber“, do good deeds and talk about it 😉 Regards, Thomas

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 2/20/19 8:06 AM, Bernhard Reutner-Fischer wrote: > On 19 February 2019 19:18:21 CET, Steve Kargl > wrote: >> On Mon, Feb 18, 2019 at 02:23:34PM +0100, Martin Liška wrote: >>> >>> As I installed all needed patches, I'm sending a documentation entry >>> for the new functionality. >>> >>> Thought

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 19 February 2019 19:18:21 CET, Steve Kargl wrote: >On Mon, Feb 18, 2019 at 02:23:34PM +0100, Martin Liška wrote: >> >> As I installed all needed patches, I'm sending a documentation entry >> for the new functionality. >> >> Thoughts? > >See below. Ok to commit with suggested changes. > >> T

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Mon, Feb 18, 2019 at 02:23:34PM +0100, Martin Liška wrote: > > As I installed all needed patches, I'm sending a documentation entry > for the new functionality. > > Thoughts? See below. Ok to commit with suggested changes. > Thanks, > Martin > >From 2d304e3b1d734548811f963c5bed1855b5375c43

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/27/18 10:11 PM, Thomas Koenig wrote: > Am 27.11.18 um 17:22 schrieb Steve Ellcey: >> Why wouldn't clang (flang) want to use the same mechanism as >> GCC/gfortran?  I know there is some interest/work going on here for >> flang and we would like a consistent way to use pre-includes to define >>

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Mon, 14 Jan 2019, Martin Liška wrote: > Thanks for review, fixed that in updated version of the patch. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? This patch is OK. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 1/11/19 7:06 PM, Joseph Myers wrote: > On Fri, 11 Jan 2019, Martin Liška wrote: > >> +/* Same as add_prefix, but prepending target_sysroot_hdrs_suffix to prefix. >> */ > > Actually, it should be prepending target_system_root, but followed by > target_sysroot_hdrs_suffix rather than target_s

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Fri, 11 Jan 2019, Martin Liška wrote: > +/* Same as add_prefix, but prepending target_sysroot_hdrs_suffix to prefix. > */ Actually, it should be prepending target_system_root, but followed by target_sysroot_hdrs_suffix rather than target_sysroot_suffix. That is, this function should be fo

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 1/9/19 6:15 PM, Joseph Myers wrote: > On Wed, 9 Jan 2019, Martin Liška wrote: > >> Hi. >> >> May I please ping that Joseph. The provided patch should be applicable and >> I would need help with the proper locations. > > I'm not clear if there is a specific question here, or a patch needing >

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Wed, 9 Jan 2019, Joseph Myers wrote: > Also, could you clarify what, in the patch > (if that's > still the current version), > > > + add_sysrooted_hdrs_prefix (&prefixes, argv[2], NULL, 0, 0, false); > > is doing (that is, examples

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Wed, 9 Jan 2019, Martin Liška wrote: > Hi. > > May I please ping that Joseph. The provided patch should be applicable and > I would need help with the proper locations. I'm not clear if there is a specific question here, or a patch needing review. In

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/30/18 2:51 PM, Martin Liška wrote: > On 11/27/18 2:40 PM, Martin Liška wrote: >> On 11/26/18 7:44 PM, Joseph Myers wrote: >>> On Mon, 26 Nov 2018, Martin Liška wrote: >>> > I don't see how this version ensures that NATIVE_SYSTEM_HEADER_DIR is > properly sysrooted. Note there's add_s

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/27/18 2:40 PM, Martin Liška wrote: > On 11/26/18 7:44 PM, Joseph Myers wrote: >> On Mon, 26 Nov 2018, Martin Liška wrote: >> I don't see how this version ensures that NATIVE_SYSTEM_HEADER_DIR is properly sysrooted. Note there's add_sysrooted_prefix separate from add_prefix (

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

Am 27.11.18 um 17:22 schrieb Steve Ellcey: Why wouldn't clang (flang) want to use the same mechanism as GCC/gfortran? I know there is some interest/work going on here for flang and we would like a consistent way to use pre-includes to define SIMD vector functions in both gfortran and flang. I t

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Mon, 2018-11-26 at 17:35 +0100, Martin Liška wrote: > On 11/26/18 5:19 PM, Matthias Klose wrote: > > On 26.11.18 13:20, Martin Liška wrote: > > > On 11/23/18 7:08 PM, Joseph Myers wrote: > > > > In the multiarch case, do you want > > > > /include/finclude/ or > > > > /include//finclude? (This

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/26/18 7:44 PM, Joseph Myers wrote: > On Mon, 26 Nov 2018, Martin Liška wrote: > >>> I don't see how this version ensures that NATIVE_SYSTEM_HEADER_DIR is >>> properly sysrooted. Note there's add_sysrooted_prefix separate from >>> add_prefix (but that's *not* the correct thing to use here

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/26/18 7:33 PM, Joseph Myers wrote: > On Mon, 26 Nov 2018, Martin Liška wrote: > >> The header file will be install by glibc (glibc-devel package). > > To confirm: you intend to submit a patch to glibc upstream to install this > file (rather than it only being something in distribution pack

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/27/18 8:57 AM, Thomas Koenig wrote: > Hi Martin, > >> he header file will be install by glibc (glibc-devel package). > > Why actually glibc-devel?  Needing glibc-devel for fast compilation > of Fortran seems to be counter-intuitive. Maybe glibc would be better. Works for me. Martin > >

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

Hi Martin, he header file will be install by glibc (glibc-devel package). Why actually glibc-devel? Needing glibc-devel for fast compilation of Fortran seems to be counter-intuitive. Maybe glibc would be better. Regards Thomas

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Mon, 26 Nov 2018, Martin Liška wrote: > > I don't see how this version ensures that NATIVE_SYSTEM_HEADER_DIR is > > properly sysrooted. Note there's add_sysrooted_prefix separate from > > add_prefix (but that's *not* the correct thing to use here because it uses > > target_sysroot_suffix wh

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Mon, 26 Nov 2018, Martin Liška wrote: > The header file will be install by glibc (glibc-devel package). To confirm: you intend to submit a patch to glibc upstream to install this file (rather than it only being something in distribution packaging)? -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/23/18 7:08 PM, Joseph Myers wrote: > On Fri, 23 Nov 2018, Martin Liška wrote: > >> Looks the problematic is quite complex as I can understand. I prepared a >> patch >> that should hopefully follow advises provided. Hello. > > I don't see how this version ensures that NATIVE_SYSTEM_HEADER

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/26/18 5:19 PM, Matthias Klose wrote: > On 26.11.18 13:20, Martin Liška wrote: >> On 11/23/18 7:08 PM, Joseph Myers wrote: >>> In the multiarch case, do you want >>> /include/finclude/ or >>> /include//finclude? (This is where I'd hope Debian >>> / Ubuntu GCC people would comment.) >> >> M

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 26.11.18 13:20, Martin Liška wrote: > On 11/23/18 7:08 PM, Joseph Myers wrote: >> In the multiarch case, do you want >> /include/finclude/ or >> /include//finclude? (This is where I'd hope Debian >> / Ubuntu GCC people would comment.) > > Mathias can you please reply to this? this should n

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/23/18 7:08 PM, Joseph Myers wrote: > In the multiarch case, do you want > /include/finclude/ or > /include//finclude? (This is where I'd hope Debian > / Ubuntu GCC people would comment.) Mathias can you please reply to this? Thanks, Martin

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Fri, 23 Nov 2018, Martin Liška wrote: > Looks the problematic is quite complex as I can understand. I prepared a patch > that should hopefully follow advises provided. I don't see how this version ensures that NATIVE_SYSTEM_HEADER_DIR is properly sysrooted. Note there's add_sysrooted_prefix

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/22/18 3:35 PM, Joseph Myers wrote: > On Thu, 22 Nov 2018, Martin Liška wrote: > >>> (Multilib suffixes on include directories for C are more or less an >>> implementation detail of how fixed headers are arranged in the case where >>> sysroot headers suffixes are used; they aren't really ex

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Thu, 22 Nov 2018, Martin Liška wrote: > > (Multilib suffixes on include directories for C are more or less an > > implementation detail of how fixed headers are arranged in the case where > > sysroot headers suffixes are used; they aren't really expected to be a > > stable interface such tha

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On 11/20/18 7:11 PM, Joseph Myers wrote: > On Tue, 20 Nov 2018, Jakub Jelinek wrote: > >> hardcoding /usr/include looks just very wrong here. That should always be >> dependent on the configured prefix or better be relative from the driver, >> gcc should be relocatable. Or at least come from con

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Tue, 20 Nov 2018, Jakub Jelinek wrote: > hardcoding /usr/include looks just very wrong here. That should always be > dependent on the configured prefix or better be relative from the driver, > gcc should be relocatable. Or at least come from configure. It should e.g. > honor the sysroot stuf

Re: [PATCH][RFC] Extend locations where to seach for Fortran pre-include.

On Tue, Nov 20, 2018 at 03:14:02PM +0100, Martin Liška wrote: > Following patch is a follow up of the discussion we had on IRC about > locations where a Fortran pre-include should be searched. > > With the patch applied I see now: > $ strace -f -s512 ./xgcc -B. ~/Programming/testcases/usage.F90 -

[PATCH][RFC] Extend locations where to seach for Fortran pre-include.

Hi. Following patch is a follow up of the discussion we had on IRC about locations where a Fortran pre-include should be searched. With the patch applied I see now: $ strace -f -s512 ./xgcc -B. ~/Programming/testcases/usage.F90 -c 2>&1 | grep math-vector access("./x86_64-pc-linux-gnu/9.0.0/math