Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-21 Thread Martin Liška
On 11/21/2017 06:13 PM, Jeff Law wrote: On 11/21/2017 08:00 AM, Martin Liška wrote: Hi. I'm sending v2 of the patch where I fixed test-suite fallout. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin 0001-Add-quotes-for-constexpr-keywor

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-21 Thread Jeff Law
On 11/21/2017 08:00 AM, Martin Liška wrote: > Hi. > > I'm sending v2 of the patch where I fixed test-suite fallout. > > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > Ready to be installed? > Martin > > > 0001-Add-quotes-for-constexpr-keyword.patch > > > From

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-21 Thread Martin Sebor
On 11/21/2017 08:00 AM, Martin Liška wrote: Hi. I'm sending v2 of the patch where I fixed test-suite fallout. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. The changes look good to me. Thanks for the nice cleanup! Martin PS While going through the patch I notic

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-21 Thread Martin Liška
Hi. I'm sending v2 of the patch where I fixed test-suite fallout. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin >From 3195b1b71c387b1359c90f6e752e1c312120cd69 Mon Sep 17 00:00:00 2001 From: marxin Date: Wed, 15 Nov 2017 08:41:12 +0100 S

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Jonathan Wakely
On 15/11/17 10:04 -0700, Martin Sebor wrote: On 11/15/2017 09:38 AM, Jonathan Wakely wrote: On 15/11/17 09:30 -0700, Martin Sebor wrote: On 11/15/2017 05:45 AM, Martin Liška wrote: On 11/06/2017 07:29 PM, Martin Sebor wrote: Sorry for being late with my comment. I just spotted this minor for

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Martin Sebor
On 11/15/2017 09:38 AM, Jonathan Wakely wrote: On 15/11/17 09:30 -0700, Martin Sebor wrote: On 11/15/2017 05:45 AM, Martin Liška wrote: On 11/06/2017 07:29 PM, Martin Sebor wrote: Sorry for being late with my comment. I just spotted this minor formatting issue. Even though GCC isn't (yet) co

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Jonathan Wakely
On 15/11/17 09:30 -0700, Martin Sebor wrote: On 11/15/2017 05:45 AM, Martin Liška wrote: On 11/06/2017 07:29 PM, Martin Sebor wrote: Sorry for being late with my comment. I just spotted this minor formatting issue. Even though GCC isn't (yet) consistent about it the keyword "constexpr" should

Re: [PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Martin Sebor
On 11/15/2017 05:45 AM, Martin Liška wrote: On 11/06/2017 07:29 PM, Martin Sebor wrote: Sorry for being late with my comment. I just spotted this minor formatting issue. Even though GCC isn't (yet) consistent about it the keyword "constexpr" should be quoted in the error message below (and, ev

[PATCH][RFC] Add quotes for constexpr keyword.

2017-11-15 Thread Martin Liška
On 11/06/2017 07:29 PM, Martin Sebor wrote: > Sorry for being late with my comment.  I just spotted this minor > formatting issue.  Even though GCC isn't (yet) consistent about > it the keyword "constexpr" should be quoted in the error message > below (and, eventually, in all diagnostic messages).