Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Florian Weimer
* Jeff Law: > But I still think we're going to want to explicitly test the various > cases where we want to see probes vs when we do not. That kind of > testing won't be covered unless we explicitly do so and the least > painful way to cover may be via dump messages or the unit testing > framewor

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Jeff Law
On 06/22/2017 12:23 PM, Florian Weimer wrote: > * Mike Stump: > >> On Jun 22, 2017, at 8:32 AM, Jeff Law wrote: >>> >>> Sure. I'll do something with 20031023-1.c to ensure it or an equivalent >>> is compiled with -fstack-check. That isn't totally unexpected. I >>> would have also been recepti

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Jakub Jelinek
On Thu, Jun 22, 2017 at 08:42:54PM +0200, Richard Biener wrote: > >The thought of scanning the assembly code or RTL is too painful to > >contemplate. THus I've been pondering having the prologue expanders > >emit notes into the dump file about what they did and why WRT probing. > > > >Or maybe we

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Richard Biener
On June 22, 2017 7:17:16 PM GMT+02:00, Jeff Law wrote: >On 06/22/2017 11:07 AM, Jakub Jelinek wrote: >> On Thu, Jun 22, 2017 at 10:02:16AM -0700, Mike Stump wrote: >>> On Jun 22, 2017, at 8:32 AM, Jeff Law wrote: Sure. I'll do something with 20031023-1.c to ensure it or an >equivalent

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Florian Weimer
* Mike Stump: > On Jun 22, 2017, at 8:32 AM, Jeff Law wrote: >> >> Sure. I'll do something with 20031023-1.c to ensure it or an equivalent >> is compiled with -fstack-check. That isn't totally unexpected. I >> would have also been receptive to adding -fstack-check to the torture flags. > > O

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Jeff Law
On 06/22/2017 11:07 AM, Jakub Jelinek wrote: > On Thu, Jun 22, 2017 at 10:02:16AM -0700, Mike Stump wrote: >> On Jun 22, 2017, at 8:32 AM, Jeff Law wrote: >>> >>> Sure. I'll do something with 20031023-1.c to ensure it or an equivalent >>> is compiled with -fstack-check. That isn't totally unexpe

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Andrew Pinski
On Thu, Jun 22, 2017 at 10:02 AM, Mike Stump wrote: > On Jun 22, 2017, at 8:32 AM, Jeff Law wrote: >> >> Sure. I'll do something with 20031023-1.c to ensure it or an equivalent >> is compiled with -fstack-check. That isn't totally unexpected. I >> would have also been receptive to adding -fst

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Jakub Jelinek
On Thu, Jun 22, 2017 at 10:02:16AM -0700, Mike Stump wrote: > On Jun 22, 2017, at 8:32 AM, Jeff Law wrote: > > > > Sure. I'll do something with 20031023-1.c to ensure it or an equivalent > > is compiled with -fstack-check. That isn't totally unexpected. I > > would have also been receptive to

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Mike Stump
On Jun 22, 2017, at 8:32 AM, Jeff Law wrote: > > Sure. I'll do something with 20031023-1.c to ensure it or an equivalent > is compiled with -fstack-check. That isn't totally unexpected. I > would have also been receptive to adding -fstack-check to the torture flags. Ouch. Though stack check

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Jeff Law
On 06/22/2017 09:29 AM, Richard Earnshaw (lists) wrote: > On 22/06/17 16:01, Jeff Law wrote: >> This fixes a bug discovered when we were evaluating the current state of >> -fstack-check. It ought to be able to go forward independent of the >> rest of the -fstack-check work. >> >> The aarch64 speci

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Richard Earnshaw (lists)
On 22/06/17 16:01, Jeff Law wrote: > This fixes a bug discovered when we were evaluating the current state of > -fstack-check. It ought to be able to go forward independent of the > rest of the -fstack-check work. > > The aarch64 specific code does not correctly handle large frames and > will gen

Re: [PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Jakub Jelinek
On Thu, Jun 22, 2017 at 09:01:03AM -0600, Jeff Law wrote: > This fixes a bug discovered when we were evaluating the current state of > -fstack-check. It ought to be able to go forward independent of the > rest of the -fstack-check work. > > The aarch64 specific code does not correctly handle larg

[PATCH][RFA] Fix -fstack-check with really big frames on aarch64

2017-06-22 Thread Jeff Law
This fixes a bug discovered when we were evaluating the current state of -fstack-check. It ought to be able to go forward independent of the rest of the -fstack-check work. The aarch64 specific code does not correctly handle large frames and will generate RTL with unrecognizable insns for such ca