Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-09-08 Thread Jeff Law
On 08/23/2017 10:39 AM, Richard Biener wrote: > On August 23, 2017 6:36:32 PM GMT+02:00, Jeff Law wrote: >> On 08/23/2017 03:07 AM, Richard Biener wrote: >> > Both -fstack-clash-protection and -fstack-check cannot be turned > off per function. This means they would need merging in >> lto-

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-23 Thread Richard Biener
On August 23, 2017 6:36:32 PM GMT+02:00, Jeff Law wrote: >On 08/23/2017 03:07 AM, Richard Biener wrote: > Both -fstack-clash-protection and -fstack-check cannot be turned off per function. This means they would need merging in >lto-wrapper. The alternative is to mark them with 'Opt

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-23 Thread Jeff Law
On 08/23/2017 03:07 AM, Richard Biener wrote: >>> Both -fstack-clash-protection and -fstack-check cannot be turned >>> off per function. This means they would need merging in lto-wrapper. >>> The alternative is to mark them with 'Optimization' and allow per-function >>> specification (like we do

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-23 Thread Richard Biener
On Tue, Aug 22, 2017 at 5:52 PM, Jeff Law wrote: > On 08/18/2017 08:01 AM, Richard Biener wrote: >> On Mon, Jul 31, 2017 at 7:35 AM, Jeff Law wrote: >>> This patch introduces the stack clash protection options >>> >>> Changes since V2: >>> >>> Adds two new params. The first controls the size of

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-22 Thread Jeff Law
On 08/22/2017 10:26 AM, David Malcolm wrote: >> Thanks. I settled on the %< %> style. None of the other warnings in >> that area use either. Otherwise I would have just selected whatever >> was >> most commonly used in that code. > > A nit that don't seem to have been mentioned: the patch refer

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-22 Thread David Malcolm
On Tue, 2017-08-22 at 09:35 -0600, Jeff Law wrote: > On 08/19/2017 12:22 PM, Martin Sebor wrote: > > On 07/30/2017 11:35 PM, Jeff Law wrote: > > > This patch introduces the stack clash protection options > > > > > > Changes since V2: > > > > > > Adds two new params. The first controls the size o

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-22 Thread Jeff Law
On 08/18/2017 08:01 AM, Richard Biener wrote: > On Mon, Jul 31, 2017 at 7:35 AM, Jeff Law wrote: >> This patch introduces the stack clash protection options >> >> Changes since V2: >> >> Adds two new params. The first controls the size of the guard area. >> This controls the threshold for when a

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-22 Thread Jeff Law
On 08/19/2017 12:22 PM, Martin Sebor wrote: > On 07/30/2017 11:35 PM, Jeff Law wrote: >> This patch introduces the stack clash protection options >> >> Changes since V2: >> >> Adds two new params. The first controls the size of the guard area. >> This controls the threshold for when a function pro

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-19 Thread Martin Sebor
On 07/30/2017 11:35 PM, Jeff Law wrote: This patch introduces the stack clash protection options Changes since V2: Adds two new params. The first controls the size of the guard area. This controls the threshold for when a function prologue requires probes. The second controls the probing inte

Re: [PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-08-18 Thread Richard Biener
On Mon, Jul 31, 2017 at 7:35 AM, Jeff Law wrote: > This patch introduces the stack clash protection options > > Changes since V2: > > Adds two new params. The first controls the size of the guard area. > This controls the threshold for when a function prologue requires > probes. The second contr

[PATCH][RFA/RFC] Stack clash mitigation patch 01/08 - V3

2017-07-30 Thread Jeff Law
This patch introduces the stack clash protection options Changes since V2: Adds two new params. The first controls the size of the guard area. This controls the threshold for when a function prologue requires probes. The second controls the probing interval -- ie, once probes are needed, how of