Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-11-02 Thread Richard Biener
On Fri, Oct 30, 2015 at 9:27 PM, Jeff Law wrote: > On 10/30/2015 07:57 AM, Andreas Schwab wrote: >> >> I'm getting this regression on m68k: >> >> FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" >> >> The generated code looks equivalent, though. > > Definitely an artifact of differe

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Jeff Law
On 10/30/2015 07:57 AM, Andreas Schwab wrote: I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. Definitely an artifact of differences in branch costing. Pondering the best way to fix. jeff

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Jeff Law
On 10/30/2015 07:57 AM, Andreas Schwab wrote: I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. How cool. This test also shows the FSM bits creating an irreducible loop in cases where it's no likel

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Jeff Law
On 10/30/2015 07:57 AM, Andreas Schwab wrote: I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. This looks to be an issue with logicals & short-circuiting.. I wouldn't be surprised if we end up wit

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Jeff Law
On 10/30/2015 07:57 AM, Andreas Schwab wrote: I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. I'll take a look. THanks, jeff

Re: [PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-30 Thread Andreas Schwab
I'm getting this regression on m68k: FAIL: gcc.dg/tree-ssa/ssa-thread-11.c scan-tree-dump vrp2 "FSM" The generated code looks equivalent, though. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something co

[PATCH][PR tree-optimization/67892] Use FSM threader to handle backedges

2015-10-29 Thread Jeff Law
As as been noted in the past, the old jump threader's support for threading across a loop backedge introduces significant complexity. The most serious complexity is the need to handle processing statements a second time (as we come around the top of the loop). This requires invalidation su