Re: [PATCH][PR sanitizer/71480] Make ASan align string constants to shadow granularity.

2016-06-11 Thread Hans-Peter Nilsson
On Fri, 10 Jun 2016, Jakub Jelinek wrote: > On Fri, Jun 10, 2016 at 03:13:32PM +0300, Maxim Ostapenko wrote: > > gcc/ChangeLog: > > > > 2016-06-10 Maxim Ostapenko > > > > PR sanitizer/71480 > > * varasm.c (place_block_symbol): Adjust alignment for asan protected > > STRING_CSTs even

Re: [PATCH][PR sanitizer/71480] Make ASan align string constants to shadow granularity.

2016-06-10 Thread Jakub Jelinek
On Fri, Jun 10, 2016 at 03:13:32PM +0300, Maxim Ostapenko wrote: > gcc/ChangeLog: > > 2016-06-10 Maxim Ostapenko > > PR sanitizer/71480 > * varasm.c (place_block_symbol): Adjust alignment for asan protected > STRING_CSTs even if TREE_CONSTANT_POOL_ADDRESS_P. > > gcc/testsuit

Re: [PATCH][PR sanitizer/71480] Make ASan align string constants to shadow granularity.

2016-06-10 Thread Maxim Ostapenko
On 10/06/16 14:41, Maxim Ostapenko wrote: On 10/06/16 14:18, Jakub Jelinek wrote: On Fri, Jun 10, 2016 at 02:12:37PM +0300, Maxim Ostapenko wrote: gcc/ChangeLog: 2016-06-10 Maxim Ostapenko PR sanitizer/71480 * varasm.c (place_block_symbol): Adjust alignment for asan protected

Re: [PATCH][PR sanitizer/71480] Make ASan align string constants to shadow granularity.

2016-06-10 Thread Maxim Ostapenko
On 10/06/16 14:18, Jakub Jelinek wrote: On Fri, Jun 10, 2016 at 02:12:37PM +0300, Maxim Ostapenko wrote: gcc/ChangeLog: 2016-06-10 Maxim Ostapenko PR sanitizer/71480 * varasm.c (place_block_symbol): Adjust alignment for asan protected STRING_CSTs even if TREE_CONSTAN

Re: [PATCH][PR sanitizer/71480] Make ASan align string constants to shadow granularity.

2016-06-10 Thread Jakub Jelinek
On Fri, Jun 10, 2016 at 02:12:37PM +0300, Maxim Ostapenko wrote: > gcc/ChangeLog: > > 2016-06-10 Maxim Ostapenko > > PR sanitizer/71480 > * varasm.c (place_block_symbol): Adjust alignment for asan protected > STRING_CSTs even if TREE_CONSTANT_POOL_ADDRESS_P. This is ok. > d

[PATCH][PR sanitizer/71480] Make ASan align string constants to shadow granularity.

2016-06-10 Thread Maxim Ostapenko
Hi, this patch (preapproved by Jakub in BZ) fixes an issue with insufficient (4 byte, should be at least 8) alignment of ASan protected string constants. I can reproduce this on arm-linux-gnueabi target, but this may affect powerpc* targets too, so I enabled the testcase for both arm and powe