Re: [PATCH][OBVIOUS] Close file on return from verify-intermediate

2018-09-13 Thread Joey Ye
Committed as r264202. gcov-8 still fails at r264226 according to https://gcc.gnu.org/ml/gcc-testresults/2018-09/msg01478.html So it is confirmed that this patch doesn't resolve PR85871, as Mike hoped. Thanks, Joey On Mon, Sep 10, 2018 at 3:04 PM Martin Liška wrote: > > On 09/05/2018 03:29 PM, J

Re: [PATCH][OBVIOUS] Close file on return from verify-intermediate

2018-09-10 Thread Martin Liška
On 09/05/2018 03:29 PM, Joey Ye wrote: > This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate > returns without closing the open file. > > This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases > that it invokes verify-intermediate. Not closing an

Re: [PATCH][OBVIOUS] Close file on return from verify-intermediate

2018-09-06 Thread Mike Stump
On Sep 5, 2018, at 6:29 AM, Joey Ye wrote: > This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate > returns without closing the open file. > > This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases > that it invokes verify-intermediate. Not closin

[PATCH][OBVIOUS] Close file on return from verify-intermediate

2018-09-05 Thread Joey Ye
This is a fix to an obvious issue in gcov.exp, where proc verify-intermediate returns without closing the open file. This can be a possible fix to PR85871. gcov-8.C diffs to other gcov testcases that it invokes verify-intermediate. Not closing an open file may result in random failure quietly.