Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread François Dumont via Gcc-patches
Deeply sorry, I indeed didn't sent the patch I wanted to commit. It was in 3 commits on my side and it looks like I had miss the last one regarding the changes for _ExtractKey. But moreover I had change the ebo helper index wrongly, I missed the abi change here, thanks for fixing it. On 26/

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 16:58 +0100, Jonathan Wakely wrote: On 26/08/20 16:55 +0100, Jonathan Wakely wrote: On 26/08/20 16:30 +0100, Jonathan Wakely wrote: I'm seeing new FAILures with this: FAIL: 20_util/function_objects/searchers.cc (test for excess errors) UNRESOLVED: 20_util/function_objects/searchers

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 16:55 +0100, Jonathan Wakely wrote: On 26/08/20 16:30 +0100, Jonathan Wakely wrote: I'm seeing new FAILures with this: FAIL: 20_util/function_objects/searchers.cc (test for excess errors) UNRESOLVED: 20_util/function_objects/searchers.cc compilation failed to produce executable FAI

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 26/08/20 16:30 +0100, Jonathan Wakely wrote: On 25/08/20 15:30 +0100, Jonathan Wakely wrote: On 17/08/20 19:13 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the new proposal.     As we can't remove template parameters I simply restore those that I tried to pass differe

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-26 Thread Jonathan Wakely via Gcc-patches
On 25/08/20 15:30 +0100, Jonathan Wakely wrote: On 17/08/20 19:13 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the new proposal.     As we can't remove template parameters I simply restore those that I tried to pass differently _H2 and _ExtractKey, so eventually I only r

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-25 Thread Jonathan Wakely via Gcc-patches
On 17/08/20 19:13 +0200, François Dumont via Libstdc++ wrote: Hi     Here is the new proposal.     As we can't remove template parameters I simply restore those that I tried to pass differently _H2 and _ExtractKey, so eventually I only remove usage of _Hash which I renamed in _Unused.

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-17 Thread François Dumont via Gcc-patches
Hi     Here is the new proposal.     As we can't remove template parameters I simply restore those that I tried to pass differently _H2 and _ExtractKey, so eventually I only remove usage of _Hash which I renamed in _Unused. Maybe I can keep the doc about it in hashtable.h and just add a remar

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-06 Thread Jonathan Wakely via Gcc-patches
On 06/08/20 08:35 +0200, François Dumont wrote: On 17/07/20 1:35 pm, Jonathan Wakely wrote: I really like the general idea of getting rid of some of the complexity and not supporting infinite customization. But we can do that without changing mangled names of the _Hashtable specialiations. I

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-08-05 Thread François Dumont via Gcc-patches
On 17/07/20 1:35 pm, Jonathan Wakely wrote: On 19/12/19 20:22 +0100, François Dumont wrote: Because of this change printers.py has to be updated too. François On 11/17/19 10:15 PM, François Dumont wrote: H1 used to be a reference to the user Hash, now _Hashtable and unordered types agree

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-07-17 Thread Jonathan Wakely via Gcc-patches
On 19/12/19 20:22 +0100, François Dumont wrote: Because of this change printers.py has to be updated too. François On 11/17/19 10:15 PM, François Dumont wrote: H1 used to be a reference to the user Hash, now _Hashtable and unordered types agree on the same Hash type which is more intuitive

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2020-07-17 Thread Jonathan Wakely via Gcc-patches
On 19/11/19 00:10 +0200, Ville Voutilainen wrote: On Mon, 18 Nov 2019 at 23:41, François Dumont wrote: > Also, is > this ABI-compatible > for our unordered containers? > IMHO, yes it is. In hashtable_policy.h _H1 was the user hash which I renamed in _Hash, the same template name that for un

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2019-12-19 Thread François Dumont
Because of this change printers.py has to be updated too. François On 11/17/19 10:15 PM, François Dumont wrote: H1 used to be a reference to the user Hash, now _Hashtable and unordered types agree on the same Hash type which is more intuitive. I also chose to not support anymore a stateful r

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2019-11-18 Thread Ville Voutilainen
On Mon, 18 Nov 2019 at 23:41, François Dumont wrote: > > Also, is > > this ABI-compatible > > for our unordered containers? > > > IMHO, yes it is. > > In hashtable_policy.h _H1 was the user hash which I renamed in _Hash, > the same template name that for unordered containers. > > _H2 was always

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2019-11-18 Thread François Dumont
On 11/17/19 11:21 PM, Ville Voutilainen wrote: On Sun, 17 Nov 2019 at 23:15, François Dumont wrote: H1 used to be a reference to the user Hash, now _Hashtable and unordered types agree on the same Hash type which is more intuitive. I also chose to not support anymore a stateful ranged hash fun

Re: [PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2019-11-17 Thread Ville Voutilainen
On Sun, 17 Nov 2019 at 23:15, François Dumont wrote: > > H1 used to be a reference to the user Hash, now _Hashtable and unordered > types agree on the same Hash type which is more intuitive. > > I also chose to not support anymore a stateful ranged hash functor. We > only use _Mod_range_hashing an

[PATCH][Hashtable 5/6] Remove H1/H2 template parameters

2019-11-17 Thread François Dumont
H1 used to be a reference to the user Hash, now _Hashtable and unordered types agree on the same Hash type which is more intuitive. I also chose to not support anymore a stateful ranged hash functor. We only use _Mod_range_hashing and _Mask_range_hashing. Thanks to this simplification _M_buck