Re: [PATCH][GRAPHITE] Fix PR71351

2017-12-19 Thread Tom de Vries
On 12/19/2017 02:05 PM, Richard Biener wrote: On Tue, 19 Dec 2017, Tom de Vries wrote: On 09/21/2017 12:07 PM, Richard Biener wrote: -exit_edge = create_empty_if_region_on_edge (entry_edge, - unshare_expr (cond_expr)); This removes the fix fo

Re: [PATCH][GRAPHITE] Fix PR71351

2017-12-19 Thread Richard Biener
On Tue, 19 Dec 2017, Tom de Vries wrote: > On 09/21/2017 12:07 PM, Richard Biener wrote: > > -exit_edge = create_empty_if_region_on_edge (entry_edge, > > - unshare_expr (cond_expr)); > > This removes the fix for PR70045: > ... > diff --git a/gcc/graph

Re: [PATCH][GRAPHITE] Fix PR71351

2017-12-19 Thread Tom de Vries
On 09/21/2017 12:07 PM, Richard Biener wrote: -exit_edge = create_empty_if_region_on_edge (entry_edge, - unshare_expr (cond_expr)); This removes the fix for PR70045: ... diff --git a/gcc/graphite-isl-ast-to-gimple.c b/gcc/graphite-isl-ast-to-gi

Re: [PATCH][GRAPHITE] Fix PR71351

2017-09-21 Thread Sebastian Pop
On Thu, Sep 21, 2017 at 5:07 AM, Richard Biener wrote: > > This PR is about code generation issues with us inserting "loop header > copies" in the attempt to cover up cases where the loop doesn't run. > But we are disregarding such cases early already. Thus the simple > fix is to not emit those

[PATCH][GRAPHITE] Fix PR71351

2017-09-21 Thread Richard Biener
This PR is about code generation issues with us inserting "loop header copies" in the attempt to cover up cases where the loop doesn't run. But we are disregarding such cases early already. Thus the simple fix is to not emit those - we have no idea what values to use for reduction results anyway.