On Nov 16, 2016, at 10:58 AM, Mike Stump wrote:
>
> Yeah, I easily could have approved it as well, so no worries.
Oh. I see I did approve the original patch, sorry for not catching it. Thanks
for all your work.
On Nov 16, 2016, at 7:57 AM, Tamar Christina wrote:
>
> Forgot to include the committed patch.
>>> This is causing all test names to depend on $srcdir. A test name
>>> should never include the value of $srcdir.
>>
>> Sorry about that, committed a fix as r242500 under the obvious rule.
Yeah, I
Forgot to include the committed patch.
> -Original Message-
> From: Tamar Christina
> Sent: 16 November 2016 15:55
> To: Andreas Schwab; Mike Stump
> Cc: GCC Patches; r...@cebitec.uni-bielefeld.de; nd
> Subject: RE: [PATCH][GCC/TESTSUITE] Make test for tradition
>
> This is causing all test names to depend on $srcdir. A test name should never
> include the value of $srcdir.
Sorry about that, committed a fix as r242500 under the obvious rule.
Thanks,
Tamar
>
> Andreas.
>
> --
> Andreas Schwab, SUSE Labs, sch...@suse.de GPG Key fingerprint = 0196
> BA
On Nov 07 2016, Mike Stump wrote:
> On Nov 1, 2016, at 8:46 AM, Tamar Christina wrote:
>>
>> A glibc update recently broke this test by adding a CPP
>> macro that uses the ## string function which traditional-cpp
>> does not support.
>> The change in glibc that made the test fail is from
>> 696
> Can you remove the comment: Newlib uses ## when including stdlib.h as of
> 2007-09-07. while you are at it? I think it doesn't make any sense post the
> change unless one reads history.
>
No problem,
Thanks
> > 2016-10-31 Tamar Christina
> >
> > PR testsuite/78136
> > * gcc.dg/cpp
On Nov 1, 2016, at 8:46 AM, Tamar Christina wrote:
>
> A glibc update recently broke this test by adding a CPP
> macro that uses the ## string function which traditional-cpp
> does not support.
> The change in glibc that made the test fail is from
> 6962682ffe5e5f0373047a0b894fee7a774be254.
>
>
Ping.
From: gcc-patches-ow...@gcc.gnu.org on behalf
of Tamar Christina
Sent: Tuesday, November 1, 2016 3:46:07 PM
To: GCC Patches; r...@cebitec.uni-bielefeld.de; mikest...@comcast.net
Cc: nd
Subject: [PATCH][GCC/TESTSUITE] Make test for traditional-cpp
Hi all,
A glibc update recently broke this test by adding a CPP
macro that uses the ## string function which traditional-cpp
does not support.
The change in glibc that made the test fail is from
6962682ffe5e5f0373047a0b894fee7a774be254.
This fixes (PR78136) by changing the test to use a local
in
