Re: [PATCH][C-Family] Disable bogus shortening of DFP vs FP compare

2014-11-04 Thread Richard Biener
On Tue, 4 Nov 2014, Joseph Myers wrote: > On Tue, 4 Nov 2014, Richard Biener wrote: > > > c-family/ > > * c-common.c (shorten_compare): Do not shorten mixed > > DFP and non-DFP compares. > > OK. I think it's also wrong for get_narrower to strip conversions between > binary and deci

Re: [PATCH][C-Family] Disable bogus shortening of DFP vs FP compare

2014-11-04 Thread Joseph Myers
On Tue, 4 Nov 2014, Richard Biener wrote: > c-family/ > * c-common.c (shorten_compare): Do not shorten mixed > DFP and non-DFP compares. OK. I think it's also wrong for get_narrower to strip conversions between binary and decimal floating point at all, as all such conversions

Re: [PATCH][C-Family] Disable bogus shortening of DFP vs FP compare

2014-11-04 Thread Richard Biener
On Tue, 4 Nov 2014, Richard Biener wrote: > > On the match-and-simplify branch we expose an issue in shorten_compare > which happily transforms (double) float-var != (double) dfp-float-var > to (float) float-var != (float) dfp-float-var which is wrong > and causes > > FAIL: c-c++-common/dfp/conv

[PATCH][C-Family] Disable bogus shortening of DFP vs FP compare

2014-11-04 Thread Richard Biener
On the match-and-simplify branch we expose an issue in shorten_compare which happily transforms (double) float-var != (double) dfp-float-var to (float) float-var != (float) dfp-float-var which is wrong and causes FAIL: c-c++-common/dfp/convert-bfp-12.c -std=c++11 execution test FAIL: c-c++-commo