Re: [PATCH][C] Fix PR47939

2011-03-18 Thread Joseph S. Myers
On Fri, 18 Mar 2011, Richard Guenther wrote: > > What I think is safe in grokdeclarator is using TYPE_MAIN_VARIANT here if > > *either* the type given in the declaration specifiers is an array type > > (TREE_CODE (type) == ARRAY_TYPE, as in your previous patch) *or* the first > > declarator tha

Re: [PATCH][C] Fix PR47939

2011-03-18 Thread Richard Guenther
On Fri, 11 Mar 2011, Joseph S. Myers wrote: > On Fri, 11 Mar 2011, Richard Guenther wrote: > > > Indeed. I tried to let the array case alone (because it's so > > complicated) but failed to do so. Appearantly > > > > if (declarator->kind == cdk_array && TYPE_QUALS (element_type)) > > type

Re: [PATCH][C] Fix PR47939

2011-03-11 Thread Joseph S. Myers
On Fri, 11 Mar 2011, Richard Guenther wrote: > Indeed. I tried to let the array case alone (because it's so > complicated) but failed to do so. Appearantly > > if (declarator->kind == cdk_array && TYPE_QUALS (element_type)) > type = TYPE_MAIN_VARIANT (type); > > leaves it alone (and does

Re: [PATCH][C] Fix PR47939

2011-03-11 Thread Richard Guenther
On Thu, 10 Mar 2011, Joseph S. Myers wrote: > On Wed, 2 Mar 2011, Richard Guenther wrote: > > > 2011-03-02 Richard Guenther > > > > PR c/47939 > > * c-decl.c (grokdeclarator): Drop to the main variant only > > for array types. Drop flag_gen_aux_info check. > > I can't convince m

Re: [PATCH][C] Fix PR47939

2011-03-10 Thread Joseph S. Myers
On Wed, 2 Mar 2011, Richard Guenther wrote: > 2011-03-02 Richard Guenther > > PR c/47939 > * c-decl.c (grokdeclarator): Drop to the main variant only > for array types. Drop flag_gen_aux_info check. I can't convince myself that this is safe - that is, that it will maintain