Re: [PATCH][Arm] Remove constraint strings from define_expand constructs in the back end

2019-06-28 Thread Kyrill Tkachov
Hi Dennis, On 6/27/19 4:58 PM, Dennis Zhang wrote: Hi Kyrill, Thanks for the review! On 6/24/19 5:27 PM, Kyrill Tkachov wrote: Hi Dennis, On 6/24/19 4:13 PM, Dennis Zhang wrote: Hi, A number of Arm define_expand patterns have specified constraints for their operands. But the constraint str

Re: [PATCH][Arm] Remove constraint strings from define_expand constructs in the back end

2019-06-24 Thread Kyrill Tkachov
Hi Dennis, On 6/24/19 4:13 PM, Dennis Zhang wrote: Hi, A number of Arm define_expand patterns have specified constraints for their operands. But the constraint strings are ignored at expand time and are therefore redundant/useless. We now avoid specifying constraints in new define_expands, but

[PATCH][Arm] Remove constraint strings from define_expand constructs in the back end

2019-06-24 Thread Dennis Zhang
Hi, A number of Arm define_expand patterns have specified constraints for their operands. But the constraint strings are ignored at expand time and are therefore redundant/useless. We now avoid specifying constraints in new define_expands, but we should clean up the existing define_expand defi