Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-10-30 Thread Kyrill Tkachov
On 30/10/17 13:54, Wilco Dijkstra wrote: Kyrill Tkachov wrote: On 16/10/17 12:30, Wilco Dijkstra wrote: DImode right shifts of 1 are rarely used (6 in total in the GCC binary), so there is little benefit of the arm_ashrdi3_1bit and arm_lshrdi3_1bit patterns. ... but it's still used, and the p

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-10-30 Thread Wilco Dijkstra
Kyrill Tkachov wrote: > On 16/10/17 12:30, Wilco Dijkstra wrote: > > DImode right shifts of 1 are rarely used (6 in total in the GCC binary), > > so there is little benefit of the arm_ashrdi3_1bit and arm_lshrdi3_1bit > > patterns. > > ... but it's still used, and the patterns were put there for a

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-10-27 Thread Kyrill Tkachov
Hi Wilco, Sorry for the delay. On 16/10/17 12:30, Wilco Dijkstra wrote: ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts A left shift of 1 can always be

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-10-16 Thread Wilco Dijkstra
    ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts     A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-06-27 Thread Wilco Dijkstra
  ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts     A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-06-13 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts     A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so that

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-04-20 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts   A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so that

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-02-23 Thread Wilco Dijkstra
  ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts     A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-02-02 Thread Wilco Dijkstra
ping From: Wilco Dijkstra Sent: 17 January 2017 19:23 To: GCC Patches Cc: nd; Kyrill Tkachov; Richard Earnshaw Subject: [PATCH][ARM] Remove DImode expansions for 1-bit shifts   A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so that

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-01-17 Thread Wilco Dijkstra
kugan wrote: > Wilco Dijkstra wrote: > > +   /* Slightly disparage left shift by 1 at so we prefer adddi3.  */ > > +   if (code == ASHIFT && XEXP (x, 1) == CONST1_RTX (SImode)) > Your ChangeLog says decrease cost for ashldi3 by 1 but looks like it is > done only for SImode. Am I missing s

Re: [PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-01-17 Thread kugan
Hi Wilco, On 18/01/17 06:23, Wilco Dijkstra wrote: ChangeLog: 2017-01-17 Wilco Dijkstra * config/arm/arm.md (ashldi3): Remove shift by 1 expansion. (arm_ashldi3_1bit): Remove pattern. (ashrdi3): Remove shift by 1 expansion. (arm_ashrdi3_1bit): Remove pattern.

[PATCH][ARM] Remove DImode expansions for 1-bit shifts

2017-01-17 Thread Wilco Dijkstra
A left shift of 1 can always be done using an add, so slightly adjust rtx cost for DImode left shift by 1 so that adddi3 is preferred in all cases, and the arm_ashldi3_1bit is redundant. DImode right shifts of 1 are rarely used (6 in total in the GCC binary), so there is little benefit of the arm_