Re: [PATCH][ARM] PR driver/70132: Avoid double fclose in driver-arm.c

2016-04-28 Thread Ramana Radhakrishnan
On Thu, Apr 28, 2016 at 10:24 AM, Kyrill Tkachov wrote: > > On 21/03/16 10:41, Ramana Radhakrishnan wrote: >> >> On Fri, Mar 11, 2016 at 3:32 PM, Kyrill Tkachov >> wrote: >>> >>> Hi all, >>> >>> As reported in the PR we can end up calling fclose twice on a file, >>> causing >>> an error. >>> This

Re: [PATCH][ARM] PR driver/70132: Avoid double fclose in driver-arm.c

2016-04-28 Thread Kyrill Tkachov
On 21/03/16 10:41, Ramana Radhakrishnan wrote: On Fri, Mar 11, 2016 at 3:32 PM, Kyrill Tkachov wrote: Hi all, As reported in the PR we can end up calling fclose twice on a file, causing an error. This patch fixes that by reorganising the logic a bit to ensure we return after closing the file

Re: [PATCH][ARM] PR driver/70132: Avoid double fclose in driver-arm.c

2016-03-23 Thread Kyrill Tkachov
On 14/03/16 12:04, Bernd Schmidt wrote: On 03/11/2016 04:32 PM, Kyrill Tkachov wrote: PR driver/70132 * config/arm/driver-arm.c (host_detect_local_cpu): Set file pointer to NULL after closing file. Doesn't match the patch. Either variant is fine but please use the right combin

Re: [PATCH][ARM] PR driver/70132: Avoid double fclose in driver-arm.c

2016-03-21 Thread Ramana Radhakrishnan
On Fri, Mar 11, 2016 at 3:32 PM, Kyrill Tkachov wrote: > Hi all, > > As reported in the PR we can end up calling fclose twice on a file, causing > an error. > This patch fixes that by reorganising the logic a bit to ensure we return > after closing > the file the first time. > > Bootstrapped and t

Re: [PATCH][ARM] PR driver/70132: Avoid double fclose in driver-arm.c

2016-03-14 Thread Bernd Schmidt
On 03/11/2016 04:32 PM, Kyrill Tkachov wrote: PR driver/70132 * config/arm/driver-arm.c (host_detect_local_cpu): Set file pointer to NULL after closing file. Doesn't match the patch. Either variant is fine but please use the right combination :) Bernd

[PATCH][ARM] PR driver/70132: Avoid double fclose in driver-arm.c

2016-03-11 Thread Kyrill Tkachov
Hi all, As reported in the PR we can end up calling fclose twice on a file, causing an error. This patch fixes that by reorganising the logic a bit to ensure we return after closing the file the first time. Bootstrapped and tested on arm-none-linux-gnueabihf Ok for trunk? Thanks, Kyrill 201